Skip to content
This repository was archived by the owner on Oct 16, 2020. It is now read-only.

Commit 6b34ee0

Browse files
committed
Its questionable if attached properties can be used in markup extensions. In either case, prefix should not be used for a normal property in markup extensions.
1 parent bb4a661 commit 6b34ee0

1 file changed

Lines changed: 12 additions & 12 deletions

File tree

  • src/AddIns/DisplayBindings/WpfDesign/WpfDesign.XamlDom/Project

src/AddIns/DisplayBindings/WpfDesign/WpfDesign.XamlDom/Project/XamlProperty.cs

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -363,19 +363,19 @@ internal XmlAttribute SetAttribute(string value)
363363

364364
internal string GetNameForMarkupExtension()
365365
{
366-
string name;
367-
if (IsAttached)
368-
name = PropertyTargetType.Name + "." + PropertyName;
369-
else
370-
name = PropertyName;
371-
372-
var element = ParentObject.XmlElement;
373-
string ns = ParentObject.OwnerDocument.GetNamespaceFor(PropertyTargetType);
374-
var prefix = element.GetPrefixOfNamespace(ns);
375-
if (string.IsNullOrEmpty(prefix))
376-
return name;
366+
if (IsAttached) {
367+
string name = PropertyTargetType.Name + "." + PropertyName;
368+
369+
var element = ParentObject.XmlElement;
370+
string ns = ParentObject.OwnerDocument.GetNamespaceFor(PropertyTargetType);
371+
var prefix = element.GetPrefixOfNamespace(ns);
372+
if (string.IsNullOrEmpty(prefix))
373+
return name;
374+
else
375+
return prefix + ":" + name;
376+
}
377377
else
378-
return prefix + ":" + name;
378+
return PropertyName;
379379
}
380380

381381
/// <summary>

0 commit comments

Comments
 (0)