Fix #422 - Unable to install Microsoft.CodeAnalysis NuGet package

If a package has only dependencies on other packages and no other
content then treat the package as project package and not as a
solution package.

Author: mrward

src/AddIns/Misc/PackageManagement/Project/Src/IPackageExtensions.cs

@@ -17,6 +17,7 @@
 // DEALINGS IN THE SOFTWARE.
 
 using System;
+using System.Linq;
 using NuGet;
 
 namespace ICSharpCode.PackageManagement
@@ -45,7 +46,8 @@ public static string GetName(this IPackage package)
 
 		public static bool IsProjectPackage(this IPackage package)
 		{
-			return package.HasProjectContent();
+			return package.HasProjectContent() ||
+				package.DependencySets.SelectMany(p => p.Dependencies).Any();
 		}
 	}
 }

src/AddIns/Misc/PackageManagement/Project/Src/PackagesViewModel.cs

@@ -275,11 +275,6 @@ protected virtual IQueryable<IPackage> GetAllPackages(string searchCriteria)
 			return null;
 		}
 
-		protected virtual bool IsProjectPackage (IPackage package)
-		{
-			return package.IsProjectPackage();
-		}
-		
 		/// <summary>
 		/// Allows filtering of the packages before paging the results. Call base class method
 		/// to run default filtering.

src/AddIns/Misc/PackageManagement/Test/PackageManagement.Tests.csproj

@@ -119,12 +119,10 @@
     <Compile Include="Src\Helpers\PropertiesHelper.cs" />
     <Compile Include="Src\Helpers\SelectedProjectCollectionAssert.cs" />
     <Compile Include="Src\Helpers\SolutionHelper.cs" />
-    <Compile Include="Src\Helpers\TestableAvailablepackagesViewModel.cs" />
     <Compile Include="Src\Helpers\TestableInstalledPackageViewModel.cs" />
     <Compile Include="Src\Helpers\TestablePackageFromRepository.cs" />
     <Compile Include="Src\Helpers\TestablePackagesViewModels.cs" />
     <Compile Include="Src\Helpers\TestableProjectBehaviour.cs" />
-    <Compile Include="Src\Helpers\TestableRecentPackagesViewModel.cs" />
     <Compile Include="Src\Helpers\TestableSelectedProjectsForUpdatedPackages.cs" />
     <Compile Include="Src\Helpers\TestableSolutionSnapshot.cs" />
     <Compile Include="Src\Helpers\TestableUpdatePackagesAction.cs" />

src/AddIns/Misc/PackageManagement/Test/Src/AvailablePackagesViewModelTests.cs

@@ -30,7 +30,7 @@ namespace PackageManagement.Tests
 	[TestFixture]
 	public class AvailablePackagesViewModelTests
 	{
-		TestableAvailablePackagesViewModel viewModel;
+		AvailablePackagesViewModel viewModel;
 		PackageManagementEvents packageManagementEvents;
 		FakeRegisteredPackageRepositories registeredPackageRepositories;
 		ExceptionThrowingRegisteredPackageRepositories exceptionThrowingRegisteredPackageRepositories;
@@ -53,7 +53,7 @@ void CreateViewModel(FakeRegisteredPackageRepositories registeredPackageReposito
 			var packageViewModelFactory = new FakePackageViewModelFactory();
 			packageManagementEvents = new PackageManagementEvents();
 
-			viewModel = new TestableAvailablePackagesViewModel(
+			viewModel = new AvailablePackagesViewModel(
 				new FakePackageManagementSolution(),
 				packageManagementEvents,
 				registeredPackageRepositories, 

src/AddIns/Misc/PackageManagement/Test/Src/Helpers/TestableAvailablepackagesViewModel.cs

@@ -21,25 +21,22 @@
 
 namespace PackageManagement.Tests.Helpers
 {
-	/// <summary>
-	/// Description of TestablePackagesViewModels.
-	/// </summary>
 	public class TestablePackagesViewModels : PackagesViewModels
 	{
 		public TestablePackagesViewModels(
 			IPackageManagementSolution solution,
 			IRegisteredPackageRepositories registeredPackageRepositories,
 			IThreadSafePackageManagementEvents packageManagementEvents,
 			IPackageActionRunner actionRunner,
-			ITaskFactory taskFactory) : base()
+			ITaskFactory taskFactory)
 		{
 			var packageViewModelFactory = new PackageViewModelFactory(solution, packageManagementEvents, actionRunner);
 			var updatedPackageViewModelFactory = new UpdatedPackageViewModelFactory(packageViewModelFactory);
 
-			AvailablePackagesViewModel = new TestableAvailablePackagesViewModel(solution, packageManagementEvents, registeredPackageRepositories, packageViewModelFactory, taskFactory);
+			AvailablePackagesViewModel = new AvailablePackagesViewModel(solution, packageManagementEvents, registeredPackageRepositories, packageViewModelFactory, taskFactory);
 			InstalledPackagesViewModel = new InstalledPackagesViewModel(solution, packageManagementEvents, registeredPackageRepositories, packageViewModelFactory, taskFactory);
 			UpdatedPackagesViewModel = new UpdatedPackagesViewModel(solution, packageManagementEvents, registeredPackageRepositories, updatedPackageViewModelFactory, taskFactory);
-			RecentPackagesViewModel = new TestableRecentPackagesViewModel(solution, packageManagementEvents, registeredPackageRepositories, packageViewModelFactory, taskFactory);
+			RecentPackagesViewModel = new RecentPackagesViewModel(solution, packageManagementEvents, registeredPackageRepositories, packageViewModelFactory, taskFactory);
 		}
 	}
 }

src/AddIns/Misc/PackageManagement/Test/Src/Helpers/TestablePackagesViewModels.cs

@@ -32,7 +32,28 @@ public class IPackageExtensionsTests
 
 		void CreatePackageWithSummary(string summary)
 		{
-			package = new FakePackage() { Summary = summary };
+			package = new FakePackage { Summary = summary };
+		}
+
+		void CreatePackageWithTitle(string title)
+		{
+			package = new FakePackage { Title = title };
+		}
+		
+		void CreatePackageWithNoProjectContent()
+		{
+			package = new FakePackage();
+		}
+		
+		void CreatePackageWithProjectContent()
+		{
+			CreatePackageWithNoProjectContent();
+			package.FrameworkAssembliesList.Add(new FrameworkAssemblyReference("System.Xml"));
+		}
+		
+		void AddDependencyToPackage()
+		{
+			package.AddDependency("Id");
 		}
 
 		[Test]
@@ -66,5 +87,68 @@ public void SummaryOrDescription_PackageHasDescriptionButEmptySummary_ReturnsDes
 
 			Assert.AreEqual("description", result);
 		}
+		
+		[Test]
+		public void GetName_PackageHasTitle_ReturnsTitle()
+		{
+			CreatePackageWithTitle("title");
+			
+			string result = package.GetName();
+			
+			Assert.AreEqual("title", result);
+		}
+		
+		[Test]
+		public void GetName_PackageHasNullTitle_ReturnsPackageId()
+		{
+			CreatePackageWithTitle(null);
+			package.Id = "Id";
+			
+			string result = package.GetName();
+			
+			Assert.AreEqual("Id", result);
+		}
+		
+		[Test]
+		public void GetName_PackageHasEmptyStringTitle_ReturnsPackageId()
+		{
+			CreatePackageWithTitle(String.Empty);
+			package.Id = "Id";
+			
+			string result = package.GetName();
+			
+			Assert.AreEqual("Id", result);
+		}
+		
+		[Test]
+		public void IsProjectPackage_PackageHasNoProjectContent_ReturnsFalse()
+		{
+			CreatePackageWithNoProjectContent();
+			
+			bool result = package.IsProjectPackage();
+			
+			Assert.IsFalse(result);
+		}
+		
+		[Test]
+		public void IsProjectPackage_PackageHasProjectContent_ReturnsTrie()
+		{
+			CreatePackageWithProjectContent();
+			
+			bool result = package.IsProjectPackage();
+			
+			Assert.IsTrue(result);
+		}
+		
+		[Test]
+		public void IsProjectPackage_PackageHasNoProjectContentButHasDependency_ReturnsTrue()
+		{
+			CreatePackageWithNoProjectContent();
+			AddDependencyToPackage();
+			
+			bool result = package.IsProjectPackage();
+			
+			Assert.IsTrue(result);
+		}
 	}
 }

src/AddIns/Misc/PackageManagement/Test/Src/Helpers/TestableRecentPackagesViewModel.cs

@@ -27,7 +27,7 @@ namespace PackageManagement.Tests
 	[TestFixture]
 	public class RecentPackagesViewModelTests
 	{
-		TestableRecentPackagesViewModel viewModel;
+		RecentPackagesViewModel viewModel;
 		PackageManagementEvents packageManagementEvents;
 		FakeRegisteredPackageRepositories registeredPackageRepositories;
 		FakeTaskFactory taskFactory;
@@ -43,7 +43,7 @@ void CreateViewModel(FakeRegisteredPackageRepositories registeredPackageReposito
 			taskFactory = new FakeTaskFactory();
 			var packageViewModelFactory = new FakePackageViewModelFactory();
 			packageManagementEvents = new PackageManagementEvents();
-			viewModel = new TestableRecentPackagesViewModel(
+			viewModel = new RecentPackagesViewModel(
 				new FakePackageManagementSolution(),
 				packageManagementEvents,
 				registeredPackageRepositories,