PM: Duplicate functionality removed & rename

1) GetPackagesInstaledInSolution() removed. Duplicate, does nothing,
redirects to public available Solution.GetPackages()

2) IsPackageInstaledInSolution() removed. Duplicate, does nothing,
redirects to public available Solution.IsPackageInstalled()

3) Name GetInstalledPackages() renamed to GetPackages().
Misleading name, all packages are installed in
selected-projects/project/solution.
Or packages exist in repository, where repository can be
available/solution/project/installed.

Author: Dragan

src/AddIns/Misc/PackageManagement/Project/Src/PackageManagementSelectedProjects.cs

@@ -138,26 +138,16 @@ public bool IsPackageInstalled(IPackageFromRepository package)
 				IPackageManagementProject project = GetSingleProjectSelected(package.Repository);
 				return project.IsPackageInstalled(package);
 			}
-			return IsPackageInstalledInSolution(package);
-		}
-		
-		public bool IsPackageInstalledInSolution(IPackage package)
-		{
 			return Solution.IsPackageInstalled(package);
 		}
 
-		public IQueryable<IPackage> GetPackagesInstalledInSolution()
-		{
-			return Solution.GetPackages();
-		}
-		
-		public IQueryable<IPackage> GetInstalledPackages(IPackageRepository sourceRepository)
+		public IQueryable<IPackage> GetPackages(IPackageRepository sourceRepository)
 		{
 			if (HasSingleProjectSelected()) {
 				IPackageManagementProject project = GetSingleProjectSelected(sourceRepository);
 				return project.GetPackages();
 			}
-			return GetPackagesInstalledInSolution();
+			return Solution.GetPackages();
 		}
 
 		public IPackageManagementProject GetSingleProjectSelected(IPackageRepository repository)

src/AddIns/Misc/PackageManagement/Project/Src/UpdatedPackagesViewModel.cs

@@ -86,7 +86,7 @@ protected override void UpdateRepositoryBeforeReadPackagesTaskStarts()
 
 		IQueryable<IPackage> GetInstalledPackages(IPackageRepository aggregateRepository)
 		{
-			return selectedProjects.GetInstalledPackages(aggregateRepository);
+			return selectedProjects.GetPackages(aggregateRepository);
 		}
 
 		protected override IQueryable<IPackage> GetAllPackages()

src/AddIns/Misc/PackageManagement/Test/Src/PackageManagementSelectedProjectsTests.cs

@@ -301,7 +301,7 @@ public void IsPackageInstalledInSolution_PackageInstalledInSolutionWithTwoProjec
 			fakeSolution.FakeInstalledPackages.Add(package);
 			CreateSelectedProjects();
 
-			bool installed = selectedProjects.IsPackageInstalledInSolution(package);
+			bool installed = selectedProjects.Solution.IsPackageInstalled(package);
 
 			Assert.IsTrue(installed);
 		}
@@ -316,7 +316,7 @@ public void IsPackageInstalledInSolution_PackageNotInstalledInSolutionWithTwoPro
 
 			var package = new FakePackage("Test");
 
-			bool installed = selectedProjects.IsPackageInstalledInSolution(package);
+			bool installed = selectedProjects.Solution.IsPackageInstalled(package);
 
 			Assert.IsFalse(installed);
 		}
@@ -332,7 +332,7 @@ public void GetPackagesInstalledInSolution_PackageInstalledInSolutionAndProjectN
 			fakeSolution.FakeInstalledPackages.Add(package);
 			CreateSelectedProjects();
 
-			IQueryable<IPackage> packages = selectedProjects.GetPackagesInstalledInSolution();
+			IQueryable<IPackage> packages = selectedProjects.Solution.GetPackages();
 
 			var expectedPackages = new FakePackage[] {
 				package
@@ -439,7 +439,7 @@ public void GetInstalledPackages_PackageInstalledInSolutionAndProjectNotSelected
 			CreateSelectedProjects();
 
 			var repository = new FakePackageRepository();
-			IQueryable<IPackage> packages = selectedProjects.GetInstalledPackages(repository);
+			IQueryable<IPackage> packages = selectedProjects.GetPackages(repository);
 
 			var expectedPackages = new FakePackage[] {
 				package
@@ -463,7 +463,7 @@ public void GetInstalledPackages_PackageInstalledInProjectAndProjectIsSelected_R
 			CreateSelectedProjects();
 
 			var repository = new FakePackageRepository();
-			IQueryable<IPackage> packages = selectedProjects.GetInstalledPackages(repository);
+			IQueryable<IPackage> packages = selectedProjects.GetPackages(repository);
 
 			var expectedPackages = new FakePackage[] {
 				package
@@ -481,7 +481,7 @@ public void GetInstalledPackages_PackageInstalledInProjectAndProjectIsSelected_C
 			CreateSelectedProjects();
 
 			var expectedRepository = new FakePackageRepository();
-			IQueryable<IPackage> packages = selectedProjects.GetInstalledPackages(expectedRepository);
+			IQueryable<IPackage> packages = selectedProjects.GetPackages(expectedRepository);
 
 			IPackageRepository repository = fakeSolution.RepositoryPassedToGetProject;