Fix bugs in #505

Author: dgrunwald

src/AddIns/DisplayBindings/AvalonEdit.AddIn/Src/Options/NamedColorHighlightingItem.cs

@@ -70,7 +70,7 @@ public bool Italic {
 
 		public bool Underline {
 			get {
-				return color.Underline;
+				return color.Underline == true;
 			}
 			set {
 				throw new NotSupportedException();

src/Libraries/AvalonEdit/ICSharpCode.AvalonEdit/Highlighting/HighlightingColor.cs

@@ -86,8 +86,8 @@ public FontStyle? FontStyle {
 		}
 
 		/// <summary>
-      ///  Gets/sets the underline flag. Null if the underline status does not change the font style.
-      /// </summary>
+		///  Gets/sets the underline flag. Null if the underline status does not change the font style.
+		/// </summary>
 		public bool? Underline {
 			get {
 				return underline;
@@ -97,7 +97,7 @@ public bool? Underline {
 					throw new InvalidOperationException();
 				underline = value;
 			}
-      }    
+		}
 
 		/// <summary>
 		/// Gets/sets the foreground color applied by the highlighting.
@@ -146,6 +146,8 @@ protected HighlightingColor(SerializationInfo info, StreamingContext context)
 				this.FontWeight = System.Windows.FontWeight.FromOpenTypeWeight(info.GetInt32("Weight"));
 			if (info.GetBoolean("HasStyle"))
 				this.FontStyle = (FontStyle?)new FontStyleConverter().ConvertFromInvariantString(info.GetString("Style"));
+			if (info.GetBoolean("HasUnderline"))
+				this.Underline = info.GetBoolean("Underline");
 			this.Foreground = (HighlightingBrush)info.GetValue("Foreground", typeof(HighlightingBrush));
 			this.Background = (HighlightingBrush)info.GetValue("Background", typeof(HighlightingBrush));
 		}
@@ -169,6 +171,9 @@ public virtual void GetObjectData(SerializationInfo info, StreamingContext conte
 			info.AddValue("HasStyle", this.FontStyle.HasValue);
 			if (this.FontStyle.HasValue)
 				info.AddValue("Style", this.FontStyle.Value.ToString());
+			info.AddValue("HasUnderline", this.Underline.HasValue);
+			if (this.Underline.HasValue)
+				info.AddValue("Underline", this.Underline.Value);
 			info.AddValue("Foreground", this.Foreground);
 			info.AddValue("Background", this.Background);
 		}
@@ -196,6 +201,12 @@ public virtual string ToCss()
 				b.Append(FontStyle.Value.ToString().ToLowerInvariant());
 				b.Append("; ");
 			}
+			if (Underline != null)
+			{
+				b.Append("text-decoration: ");
+				b.Append(Underline.Value ? "underline" : "none");
+				b.Append("; ");
+			}
 			return b.ToString();
 		}
 
@@ -247,7 +258,9 @@ public virtual bool Equals(HighlightingColor other)
 		{
 			if (other == null)
 				return false;
-			return this.name == other.name && this.fontWeight == other.fontWeight && this.fontStyle == other.fontStyle && object.Equals(this.foreground, other.foreground) && object.Equals(this.background, other.background);
+			return this.name == other.name && this.fontWeight == other.fontWeight
+				&& this.fontStyle == other.fontStyle && this.underline == other.underline
+				&& object.Equals(this.foreground, other.foreground) && object.Equals(this.background, other.background);
 		}
 
 		/// <inheritdoc/>
@@ -282,11 +295,14 @@ public void MergeWith(HighlightingColor color)
 				this.foreground = color.foreground;
 			if (color.background != null)
 				this.background = color.background;
+			if (color.underline != null)
+				this.underline = color.underline;
 		}
 
 		internal bool IsEmptyForMerge {
 			get {
-				return fontWeight == null && fontStyle == null && foreground == null && background == null;
+				return fontWeight == null && fontStyle == null && underline == null
+					&& foreground == null && background == null;
 			}
 		}
 	}

src/Libraries/AvalonEdit/ICSharpCode.AvalonEdit/Highlighting/Resources/ModeV2.xsd

@@ -24,7 +24,6 @@
 	<xsd:simpleType name="FontStyle">
 		<xsd:restriction base="xsd:string">
 			<xsd:enumeration value="italic"/>
-		   <xsd:enumeration value="underlined"/>
 			<xsd:enumeration value="normal"/>
 			<xsd:enumeration value="oblique"/>
 		</xsd:restriction>

src/Libraries/AvalonEdit/ICSharpCode.AvalonEdit/Highlighting/Xshd/V2Loader.cs

@@ -297,7 +297,7 @@ static XshdColor ParseColorAttributes(XmlReader reader)
 			color.Background = ParseColor(position, reader.GetAttribute("background"));
 			color.FontWeight = ParseFontWeight(reader.GetAttribute("fontWeight"));
 			color.FontStyle = ParseFontStyle(reader.GetAttribute("fontStyle"));
-			color.Underline = reader.GetAttribute("underline") == "true";
+			color.Underline = reader.GetBoolAttribute("underline");
 			return color;
 		}
 

src/Libraries/AvalonEdit/ICSharpCode.AvalonEdit/Highlighting/Xshd/XshdColor.cs

@@ -52,7 +52,7 @@ public class XshdColor : XshdElement, ISerializable
 		/// <summary>
 		/// Gets/sets the underline flag
 		/// </summary>
-		public bool Underline { get; set; }
+		public bool? Underline { get; set; }
 
 		/// <summary>
 		/// Gets/sets the font style.
@@ -86,7 +86,8 @@ protected XshdColor(SerializationInfo info, StreamingContext context)
 			if (info.GetBoolean("HasStyle"))
 				this.FontStyle = (FontStyle?)new FontStyleConverter().ConvertFromInvariantString(info.GetString("Style"));
 			this.ExampleText = info.GetString("ExampleText");
-			this.Underline = info.GetBoolean("Underline");
+			if (info.GetBoolean("HasUnderline"))
+				this.Underline = info.GetBoolean("Underline");
 		}
 
 		/// <summary>
@@ -104,9 +105,10 @@ public virtual void GetObjectData(SerializationInfo info, StreamingContext conte
 			info.AddValue("Name", this.Name);
 			info.AddValue("Foreground", this.Foreground);
 			info.AddValue("Background", this.Background);
+			info.AddValue("HasUnderline", this.Underline.HasValue);
+			if (this.Underline.HasValue)
+				info.AddValue("Underline", this.Underline.Value);
 			info.AddValue("HasWeight", this.FontWeight.HasValue);
-			if (this.Underline)
-				info.AddValue("Underline", this.Underline);			
 			if (this.FontWeight.HasValue)
 				info.AddValue("Weight", this.FontWeight.Value.ToOpenTypeWeight());
 			info.AddValue("HasStyle", this.FontStyle.HasValue);