If properties on a markup extension (for example a binding) is modified after the markup extension was set on a property, and these property changes effect how the markup extension can be printed in XAML, the markup extension was not updated properly.

Author: gumme

src/AddIns/DisplayBindings/WpfDesign/WpfDesign.Designer/Tests/Designer/ModelTests.cs

@@ -319,8 +319,7 @@ public void AddBindingWithStaticResource()
 			AssertLog("");
 		}
 
-		[Test]
-		public void AddBindingWithStaticResourceWhereResourceOnSameElement()
+		void AddBindingWithStaticResourceWhereResourceOnSameElement(bool setBindingPropertiesAfterSet)
 		{
 			DesignItem button = CreateCanvasContext("<Button/>");
 			DesignItem canvas = button.Parent;
@@ -334,10 +333,17 @@ public void AddBindingWithStaticResourceWhereResourceOnSameElement()
 			resProp.CollectionElements.Add(exampleClassItem);
 
 			DesignItem bindingItem = canvas.Services.Component.RegisterComponentForDesigner(new Binding());
-			bindingItem.Properties["Path"].SetValue("StringProp");
-			bindingItem.Properties["Source"].SetValue(new StaticResourceExtension());
-			bindingItem.Properties["Source"].Value.Properties["ResourceKey"].SetValue("bindingSource");
+			if (!setBindingPropertiesAfterSet) {
+				bindingItem.Properties["Path"].SetValue("StringProp");
+				bindingItem.Properties["Source"].SetValue(new StaticResourceExtension());
+				bindingItem.Properties["Source"].Value.Properties["ResourceKey"].SetValue("bindingSource");
+			}
 			textBox.Properties[TextBox.TextProperty].SetValue(bindingItem);
+			if (setBindingPropertiesAfterSet) {
+				bindingItem.Properties["Path"].SetValue("StringProp");
+				bindingItem.Properties["Source"].SetValue(new StaticResourceExtension());
+				bindingItem.Properties["Source"].Value.Properties["ResourceKey"].SetValue("bindingSource");
+			}
 
 			string expectedXaml = "<Button />\n" +
 								  "<TextBox>\n" +
@@ -350,6 +356,18 @@ public void AddBindingWithStaticResourceWhereResourceOnSameElement()
 			AssertCanvasDesignerOutput(expectedXaml, button.Context);
 			AssertLog("");
 		}
+		
+		[Test]
+		public void AddBindingWithStaticResourceWhereResourceOnSameElement()
+		{
+			AddBindingWithStaticResourceWhereResourceOnSameElement(false);
+		}
+		
+		[Test]
+		public void AddBindingWithStaticResourceWhereResourceOnSameElementAlt()
+		{
+			AddBindingWithStaticResourceWhereResourceOnSameElement(true);
+		}
 	}
 
 	public class MyMultiConverter : IMultiValueConverter

src/AddIns/DisplayBindings/WpfDesign/WpfDesign.XamlDom/Project/XamlObject.cs

@@ -5,6 +5,7 @@
 using System.Collections.Generic;
 using System.ComponentModel;
 using System.Diagnostics;
+using System.Linq;
 using System.Windows.Markup;
 using System.Xml;
 using System.Windows.Data;
@@ -151,8 +152,9 @@ internal static string GetContentPropertyName(Type elementType)
 		}
 
 		internal override void AddNodeTo(XamlProperty property)
-		{	
-			if (!UpdateXmlAttribute(true)) {
+		{
+			XamlObject holder;
+			if (!UpdateXmlAttribute(true, out holder)) {
 				property.AddChildNodeToProperty(element);
 			}
 			UpdateMarkupExtensionChain();
@@ -164,7 +166,8 @@ internal override void RemoveNodeFromParent()
 				XmlAttribute.OwnerElement.RemoveAttribute(XmlAttribute.Name);
 				xmlAttribute = null;
 			} else {
-				if (!UpdateXmlAttribute(false)) {
+				XamlObject holder;
+				if (!UpdateXmlAttribute(false, out holder)) {
 					element.ParentNode.RemoveChild(element);
 				}
 			}			
@@ -175,8 +178,28 @@ internal override void RemoveNodeFromParent()
 		//TODO: reseting path property for binding doesn't work in XamlProperty
 		//use CanResetValue()
 		internal void OnPropertyChanged(XamlProperty property)
-		{			
-			UpdateXmlAttribute(false);
+		{
+			XamlObject holder;
+			if (!UpdateXmlAttribute(false, out holder)) {
+				if (holder != null &&
+					holder.XmlAttribute != null) {
+					holder.XmlAttribute.OwnerElement.RemoveAttributeNode(holder.XmlAttribute);
+					holder.xmlAttribute = null;
+					holder.ParentProperty.AddChildNodeToProperty(holder.element);
+					
+					bool isThisUpdated = false;
+					foreach(XamlObject propXamlObject in holder.Properties.Where((prop) => prop.IsSet).Select((prop) => prop.PropertyValue).OfType<XamlObject>()) {
+						XamlObject innerHolder;
+						bool updateResult = propXamlObject.UpdateXmlAttribute(true, out innerHolder);
+						Debug.Assert(updateResult);
+						
+						if (propXamlObject == this)
+							isThisUpdated = true;
+					}
+					if (!isThisUpdated)
+						this.UpdateXmlAttribute(true, out holder);
+				}
+			}
 			UpdateMarkupExtensionChain();
 
 			if (property == NameProperty) {
@@ -194,9 +217,9 @@ void UpdateMarkupExtensionChain()
 			}			
 		}
 
-		bool UpdateXmlAttribute(bool force)
+		bool UpdateXmlAttribute(bool force, out XamlObject holder)
 		{
-			var holder = FindXmlAttributeHolder();
+			holder = FindXmlAttributeHolder();
 			if (holder == null && force && IsMarkupExtension) {
 				holder = this;
 			}