Better structure of ReportSettings in PropertyGrid

Author: PeterForstmeier

src/AddIns/Misc/Reporting/ICSharpCode.Reporting/Src/Items/ReportSettings.cs

@@ -65,33 +65,34 @@ void BaseValues()
 //			this.GraphicsUnit = GraphicsUnit.Pixel;
 //			this.Padding = new Padding(5);
 //			this.DefaultFont = GlobalValues.DefaultFont;
-			this.ReportType = GlobalEnums.ReportType.FormSheet;
+			ReportType = GlobalEnums.ReportType.FormSheet;
 //			
 			this.DataModel = GlobalEnums.PushPullModel.FormSheet;
 //			
 //			this.CommandType =  System.Data.CommandType.Text;
 //			this.ConnectionString = String.Empty;
 //			this.CommandText = String.Empty;
 //			
-			this.TopMargin = GlobalValues.DefaultPageMargin.Left;
-			this.BottomMargin = GlobalValues.DefaultPageMargin.Bottom;
-			this.LeftMargin = GlobalValues.DefaultPageMargin.Left;
-			this.RightMargin = GlobalValues.DefaultPageMargin.Right;
+			TopMargin = GlobalValues.DefaultPageMargin.Left;
+			BottomMargin = GlobalValues.DefaultPageMargin.Bottom;
+			LeftMargin = GlobalValues.DefaultPageMargin.Left;
+			RightMargin = GlobalValues.DefaultPageMargin.Right;
 //			
 //			this.availableFields = new AvailableFieldsCollection();
-//			this.groupingsCollection = new GroupColumnCollection();
-			this.SortColumnsCollection = new SortColumnCollection();
-			this.GroupColumnsCollection = new GroupColumnCollection();
+
+			SortColumnsCollection = new SortColumnCollection();
+			GroupColumnsCollection = new GroupColumnCollection();
 //			this.sqlParameters = new SqlParameterCollection();
 			ParameterCollection = new ParameterCollection();
 //			this.NoDataMessage = "No Data for this Report";
 		}
 
+		#region BaseSettings
 
 		private string reportName;
 
-//		[Category("Base Settings")]
-//		[DefaultValueAttribute ("")]
+		[Category("Base Settings")]
+		[DefaultValueAttribute ("")]
 		public string ReportName
 		{
 			get {
@@ -101,15 +102,14 @@ public string ReportName
 				return reportName;
 			}
 			set {
-				if (reportName != value) {
-					reportName = value;
-				}
+				reportName = value;
 			}
 		}
 
-		private string fileName;
-//		[Category("Base Settings")]
-//		[XmlIgnoreAttribute]
+		string fileName;
+		
+		[Category("Base Settings")]
+		[XmlIgnoreAttribute]
 		public string FileName
 		{
 			get {
@@ -124,25 +124,39 @@ public string FileName
 		}
 
 
-//		[Category("Page Settings")]
+		[Browsable(true), Category("Base Settings")]
+		public GlobalEnums.ReportType ReportType {get;set;}
+		
+		
+		[Browsable(true), Category("Base Settings")]
+		public GlobalEnums.PushPullModel DataModel {get;set;}
+		
+		#endregion
+		
+		
+		#region Pagesettings
+		
+		[Category("Page Settings")]
 		public int BottomMargin {get;set;}
 
 
-//		[Category("Page Settings")]
+		[Category("Page Settings")]
 		public int TopMargin  {get;set;}
 
 
 
-//		[Category("Page Settings")]
+		[Category("Page Settings")]
 		public int LeftMargin {get;set;}
 
 
 
-//		[Category("Page Settings")]
+		[Category("Page Settings")]
 		public int RightMargin  {get;set;}
 
+		
 		private Size pageSize;
 
+		[Category("Page Settings")]
 		public Size PageSize {
 			get {
 				if (!Landscape) {
@@ -154,18 +168,21 @@ public Size PageSize {
 			set { pageSize = value; }
 		}
 
-//		[Category("Page Settings")]
-//		public Size PageSize {get;set;}
 
-//		[Category("Page Settings")]
+		[Category("Page Settings")]
 		public bool Landscape {get;set;}
 
+		
+		#endregion
+		
+		#region
+		
+		
 //		[Category("Data")]
-		public GlobalEnums.PushPullModel DataModel {get;set;}
 
 
-//		[Browsable(true), Category("Base Settings")]
-		public GlobalEnums.ReportType ReportType {get;set;}
+		
+		
 
 
 //		[Category("Parameters")]
@@ -177,5 +194,7 @@ public Size PageSize {
 		public SortColumnCollection SortColumnsCollection {get;private set;}
 
 		public GroupColumnCollection GroupColumnsCollection {get;private set;}
+		
+		#endregion
 	}
 }