Commit c02f976
committed
Fix critical bugs in result.py and target.py
Critical bug fix - ignore_target() never matched ignored targets:
- Line 204: `ignored_target == 'IGN'` compared a dict to a string,
always evaluating to False. Fixed to `ignored_target.get('type') == 'IGN'`.
This caused duplicate ignored targets to accumulate in cracked.json.
Bug fix - load_ignored_bssids() used wrong dict key:
- Used `item.get('result_type')` but the JSON schema uses `type` key.
This caused ignored BSSIDs to never be loaded, meaning previously
ignored targets would be attacked again on restart.
Bug fix - hidden ESSID detection missed actual null bytes:
- Added `'\x00' * essid_len` check alongside the existing literal
text representations ('\\x00' and 'x00') to catch all forms of
hidden ESSID encoding from airodump-ng.
Code quality:
- Replace `raise Exception()` with `raise NotImplementedError()` in
abstract base class methods (dump, to_dict, print_single_line)
- Remove unnecessary `global result` variable in load() method
All 575 tests pass.
https://claude.ai/code/session_015S3rdrYgPHPLA4hWo6yr5g1 parent 1b153e5 commit c02f976
2 files changed
+9
-8
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
| 23 | + | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
| 26 | + | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
| 29 | + | |
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| |||
129 | 129 | | |
130 | 130 | | |
131 | 131 | | |
132 | | - | |
| 132 | + | |
133 | 133 | | |
134 | 134 | | |
135 | 135 | | |
136 | 136 | | |
137 | | - | |
| 137 | + | |
138 | 138 | | |
139 | 139 | | |
140 | 140 | | |
| |||
143 | 143 | | |
144 | 144 | | |
145 | 145 | | |
146 | | - | |
| 146 | + | |
147 | 147 | | |
148 | 148 | | |
149 | 149 | | |
150 | 150 | | |
151 | 151 | | |
152 | | - | |
| 152 | + | |
153 | 153 | | |
154 | 154 | | |
155 | 155 | | |
| |||
201 | 201 | | |
202 | 202 | | |
203 | 203 | | |
204 | | - | |
| 204 | + | |
205 | 205 | | |
206 | 206 | | |
207 | 207 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
124 | 124 | | |
125 | 125 | | |
126 | 126 | | |
| 127 | + | |
127 | 128 | | |
128 | 129 | | |
129 | 130 | | |
| |||
0 commit comments