We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
1 parent 0821679 commit 82cf803Copy full SHA for 82cf803
1 file changed
src/dataframe.rs
@@ -430,11 +430,7 @@ impl PyDataFrame {
430
431
/// Convert this DataFrame into a Table that can be used in register_table
432
/// By convention, into_... methods consume self and return the new object.
433
- /// Disabling the clippy lint, so we can use &self
434
- /// because we're working with Python bindings
435
- /// where objects are shared
436
- /// https://github.com/apache/datafusion-python/pull/1016#discussion_r1983239116
437
- /// - we have not decided on the table_provider approach yet
+ /// Here we intentionally borrow to avoid invalidating the Python wrapper.
438
#[allow(clippy::wrong_self_convention)]
439
fn into_view(&self) -> PyDataFusionResult<PyTable> {
440
// Call the underlying Rust DataFrame::into_view method.
0 commit comments