fix: rename into_view_provider to to_view_provider for clarity

Author: kosiew

src/dataframe.rs

@@ -268,8 +268,7 @@ impl PyDataFrame {
         }
     }
 
-    #[allow(clippy::wrong_self_convention)]
-    pub(crate) fn into_view_provider(&self) -> Arc<dyn TableProvider + Send> {
+    pub(crate) fn to_view_provider(&self) -> Arc<dyn TableProvider + Send> {
         self.df.as_ref().clone().into_view()
     }
 
@@ -400,17 +399,14 @@ impl PyDataFrame {
 
     /// Convert this DataFrame into a Table that can be used in register_table
     /// By convention, into_... methods consume self and return the new object.
-    /// Disabling the clippy lint, so we can use &self
-    /// because we're working with Python bindings
-    /// where objects are shared
+    /// Here we intentionally borrow to avoid invalidating the Python wrapper.
     /// https://github.com/apache/datafusion-python/pull/1016#discussion_r1983239116
     /// - we have not decided on the table_provider approach yet
-    #[allow(clippy::wrong_self_convention)]
     pub fn into_view(&self) -> PyDataFusionResult<PyTableProvider> {
         // Call the underlying Rust DataFrame::into_view method.
         // Note that the Rust method consumes self; here we clone the inner Arc<DataFrame>
         // so that we don't invalidate this PyDataFrame.
-        let table_provider = self.into_view_provider();
+        let table_provider = self.to_view_provider();
         Ok(PyTableProvider::new(table_provider))
     }
 

src/table.rs

@@ -80,7 +80,7 @@ impl PyTableProvider {
     /// This method simply delegates to `DataFrame.into_view`.
     #[staticmethod]
     pub fn from_dataframe(df: &PyDataFrame) -> PyDataFusionResult<Self> {
-        let table_provider = df.into_view_provider();
+        let table_provider = df.to_view_provider();
         Ok(Self::new(table_provider))
     }