Skip to content

Commit a05fe03

Browse files
committed
fix: update from_dataframe method to return the correct type
1 parent b5c7582 commit a05fe03

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

python/tests/test_context.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -361,7 +361,7 @@ def test_register_table_with_dataframe_errors(ctx):
361361

362362
assert (
363363
str(exc_info.value)
364-
== "Expected a Table or TableProvider. Convert DataFrames with \"DataFrame.into_view()\" or \"TableProvider.from_dataframe()\"."
364+
== 'Expected a Table or TableProvider. Convert DataFrames with "DataFrame.into_view()" or "TableProvider.from_dataframe()".'
365365
)
366366

367367

src/table.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,9 @@ impl PyTableProvider {
7979
///
8080
/// This method simply delegates to `DataFrame.into_view`.
8181
#[staticmethod]
82-
pub fn from_dataframe(df: &PyDataFrame) -> PyDataFusionResult<Self> {
82+
pub fn from_dataframe(df: &PyDataFrame) -> Self {
8383
let table_provider = df.to_view_provider();
84-
Ok(Self::new(table_provider))
84+
Self::new(table_provider)
8585
}
8686

8787
/// Create a `TableProvider` from a `DataFrame` by converting it into a view.
@@ -97,7 +97,7 @@ impl PyTableProvider {
9797
py.get_type::<PyDeprecationWarning>(),
9898
),
9999
)?;
100-
Self::from_dataframe(df)
100+
Ok(Self::from_dataframe(df))
101101
}
102102

103103
fn __datafusion_table_provider__<'py>(

0 commit comments

Comments
 (0)