Making it easier to contribute to LangChain #35700
Replies: 6 comments 3 replies
-
|
No comments ? |
Beta Was this translation helpful? Give feedback.
-
|
From my point of view, this is a sensible change because it prevents contributors from doing a lot of work on PRs that were never aligned with maintainer priorities. The only friction I would watch is the gap between opening an issue and knowing whether it is actually ready for outside work. A lightweight label or maintainer note like ready for external contribution would probably reduce the back and forth a lot for new contributors. The trusted contributor signal also seems useful. It gives repeat contributors a clearer path without weakening the review process for brand new proposals. |
Beta Was this translation helpful? Give feedback.
-
|
Makes sense for feature work, but curious how this plays out for docs fixes or small tweaks — doesn't want the overhead to kill those contributions. Probably already thought through it, but worth calling out since those PRs add up. |
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
|
Mason Daugherty (@mdrxy) You should really consider a way of banning potential contributors that just endlessly open up PRs and issues. It's clear people are setting their agents to essentially DDOS maintaners with slop. Super fustrating the good trusting nature of open source is dying. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
We shipped a few changes to how external contributions work. The goal is to save contributors time by aligning on scope before code gets written, and to help maintainers prioritize reviews more effectively.
Talk to us before you code
External PRs now need to reference an approved issue (
Fixes #123,Closes #123, orResolves #123in the PR description), and you need to be assigned to that issue. PRs that don't meet these requirements will be automatically closed — but don't worry, the bot will tell you exactly what's missing, and your PR will reopen automatically once everything checks out.The quick version:
Fixes #<number>in the description before any other contentWe especially encourage issue authors to contribute fixes — you're closest to the problem and most likely to understand the context. This process keeps everyone on the same page and avoids the frustration of putting work into a PR that we can't merge.
For the full rundown on contributing, check out our Contributing Guide.
We now recognize repeat contributors
If you've had 5 or more PRs merged, you'll automatically get a
trusted-contributorlabel on your PRs and issues. This helps maintainers spot familiar faces during triage. If you've been contributing for a while — thank you, and your PRs will reflect that now.FAQ
I'm assigned to an issue but the check still failed?
Make sure your PR description includes one of the auto-close keywords (
Fixes,Closes, orResolves) followed by the issue number. The check re-runs when you edit the description.This is a new process and we're iterating on it. If something feels off or you have suggestions, let us know in this thread.
Beta Was this translation helpful? Give feedback.
All reactions