Skip to content

Commit aaf91b7

Browse files
plappermaulhauke
authored andcommitted
realtek: mdio: harden defines
Add brackets to avoid silent bugs. Signed-off-by: Markus Stockhausen <markus.stockhausen@gmx.de> Link: openwrt/openwrt#23070 Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
1 parent 51992c8 commit aaf91b7

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

target/linux/realtek/files-6.18/drivers/net/mdio/mdio-realtek-otto.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
#define RTMDIO_PHY_MAC_1G 3
3030
#define RTMDIO_PHY_MAC_2G_PLUS 1
3131

32-
#define RTMDIO_PHY_POLL_MMD(dev, reg, bit) ((bit << 21) | (dev << 16) | reg)
32+
#define RTMDIO_PHY_POLL_MMD(dev, reg, bit) ((bit << 21) | (dev << 16) | (reg))
3333

3434
/* MDIO bus registers/fields */
3535
#define RTMDIO_RUN BIT(0)
@@ -42,7 +42,7 @@
4242
#define RTMDIO_838X_CMD_READ_C22 0
4343
#define RTMDIO_838X_CMD_READ_C45 BIT(1)
4444
#define RTMDIO_838X_CMD_WRITE_C22 BIT(2)
45-
#define RTMDIO_838X_CMD_WRITE_C45 BIT(1) | BIT(2)
45+
#define RTMDIO_838X_CMD_WRITE_C45 (BIT(1) | BIT(2))
4646
#define RTMDIO_838X_CMD_MASK GENMASK(2, 0)
4747
#define RTMDIO_838X_SMI_ACCESS_PHY_CTRL_2 (0xa1c0)
4848
#define RTMDIO_838X_SMI_ACCESS_PHY_CTRL_3 (0xa1c4)
@@ -56,7 +56,7 @@
5656
#define RTMDIO_839X_CMD_READ_C22 0
5757
#define RTMDIO_839X_CMD_READ_C45 BIT(2)
5858
#define RTMDIO_839X_CMD_WRITE_C22 BIT(3)
59-
#define RTMDIO_839X_CMD_WRITE_C45 BIT(2) | BIT(3)
59+
#define RTMDIO_839X_CMD_WRITE_C45 (BIT(2) | BIT(3))
6060
#define RTMDIO_839X_CMD_MASK GENMASK(3, 0)
6161
#define RTMDIO_839X_PHYREG_DATA_CTRL (0x03F0)
6262
#define RTMDIO_839X_PHYREG_MMD_CTRL (0x03F4)
@@ -70,8 +70,8 @@
7070
#define RTMDIO_930X_CMD_READ_C22 0
7171
#define RTMDIO_930X_CMD_READ_C45 BIT(1)
7272
#define RTMDIO_930X_CMD_WRITE_C22 BIT(2)
73-
#define RTMDIO_930X_CMD_WRITE_C45 BIT(1) | BIT(2)
74-
#define RTMDIO_930X_CMD_MASK GENMASK(2, 0) | BIT(25)
73+
#define RTMDIO_930X_CMD_WRITE_C45 (BIT(1) | BIT(2))
74+
#define RTMDIO_930X_CMD_MASK (GENMASK(2, 0) | BIT(25))
7575
#define RTMDIO_930X_SMI_ACCESS_PHY_CTRL_2 (0xCB78)
7676
#define RTMDIO_930X_SMI_ACCESS_PHY_CTRL_3 (0xCB7C)
7777
#define RTMDIO_930X_SMI_PORT0_15_POLLING_SEL (0xCA08)
@@ -92,7 +92,7 @@
9292
#define RTMDIO_931X_CMD_READ_C22 0
9393
#define RTMDIO_931X_CMD_READ_C45 BIT(3)
9494
#define RTMDIO_931X_CMD_WRITE_C22 BIT(4)
95-
#define RTMDIO_931X_CMD_WRITE_C45 BIT(3) | BIT(4)
95+
#define RTMDIO_931X_CMD_WRITE_C45 (BIT(3) | BIT(4))
9696
#define RTMDIO_931X_CMD_MASK GENMASK(4, 0)
9797
#define RTMDIO_931X_SMI_INDRT_ACCESS_CTRL_1 (0x0C04)
9898
#define RTMDIO_931X_SMI_INDRT_ACCESS_CTRL_2 (0x0C08)

0 commit comments

Comments
 (0)