Drop ISSUE/cycle workflow refs and stale line numbers from comments

Six in-source workflow citations across the client / dbapi / SA-base
("ISSUE-39", "ISSUE-159", "ISSUE-198", "ISSUE-631", "ISSUE-696",
"cycle-18") leaked from review notes into shipped source. The
surrounding prose already explains the rationale; the bare token is
a footnote-to-the-tracker that goes stale silently when issues are
renumbered or moved.

Also fix two stale line-number citations: protocol.py's heartbeat-cap
comment cited line 82 / line 106 which now hold an unrelated helper's
docstring and a parameter declaration; replace with function-name
references that survive line drift. Update _check_in_use docstring to
list all four guards (the cycle 20 fork-pid check was added but the
docstring still listed three).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: antoineleclair

src/dqliteclient/cluster.py

@@ -136,8 +136,7 @@ def __init__(
         # share the in-flight discovery task instead of each launching
         # an independent per-node sweep — under a leader flip with N
         # waiting acquirers, this collapses N×M handshake attempts
-        # against the failing ex-leader into M (one sweep). See
-        # ISSUE-631 for the stampede shape this closes. Slots are
+        # against the failing ex-leader into M (one sweep). Slots are
         # cleared on done-callback so a fresh probe re-runs after the
         # current task finishes; consecutive callers do NOT share a
         # cached failure.

src/dqliteclient/connection.py

@@ -1192,7 +1192,7 @@ async def _close_impl(self) -> None:
         # failed-connect path already clears this in ``connect()``'s
         # finally block, but the successful-close path was missing the
         # symmetry. Mirrors the loop-reset done by the dbapi-async
-        # adapter on close (``done/ISSUE-159``).
+        # adapter on close.
         self._bound_loop = None
         if self._protocol is None:
             return
@@ -1275,7 +1275,10 @@ def _ensure_connected(self) -> tuple[DqliteProtocol, int]:
         return self._protocol, self._db_id
 
     def _check_in_use(self) -> None:
-        """Raise on misuse: wrong event loop, concurrent access, or use after pool release."""
+        """Raise on misuse, in this order: cross-process (fork) use,
+        use after pool release, missing async context, wrong event
+        loop, concurrent operation, or transaction owned by another
+        task."""
         if os.getpid() != self._creator_pid:
             raise InterfaceError(
                 "Connection used after fork; reconstruct from configuration in the target process."
@@ -2136,7 +2139,7 @@ async def transaction(self) -> AsyncIterator[None]:
                     # server already auto-rolled-back. The connection
                     # is healthy; preserve it and re-raise the body
                     # exception. Mirrors the dbapi layer's
-                    # _NO_TX_CODES whitelist (ISSUE-696).
+                    # _NO_TX_CODES whitelist.
                     if _is_no_tx_rollback_error(roll_exc):
                         logger.debug(
                             "transaction(address=%s, id=%s): rollback "

src/dqliteclient/pool.py

@@ -1006,7 +1006,7 @@ async def acquire(self) -> AsyncIterator[DqliteConnection]:
                             # the user's original error. Narrow to
                             # ``RuntimeError`` so programming bugs
                             # (``AttributeError``, ``TypeError``, etc.)
-                            # still surface — see done/ISSUE-198.
+                            # still surface.
                             logger.debug(
                                 "pool.acquire cleanup: conn.close(%r) raised RuntimeError",
                                 getattr(conn, "_address", "?"),

src/dqliteclient/protocol.py

@@ -57,9 +57,10 @@
 # sane operational tuning (``config.c`` defaults to 15 s; 300 s fits
 # 20× that with plenty of headroom) while still bounding the widening
 # to a known scale. Changes here must be reflected in the
-# ``trust_server_heartbeat`` docstrings at protocol.py:82 and :106,
-# connection.py:__init__ docstring, and the top-level ``connect`` /
-# ``create_pool`` docstrings in ``__init__.py``.
+# ``trust_server_heartbeat`` docstrings on ``DqliteProtocol.__init__``
+# and ``DqliteProtocol.handshake``, ``DqliteConnection.__init__``,
+# and the top-level ``connect`` / ``create_pool`` docstrings in
+# ``__init__.py``.
 _HEARTBEAT_READ_TIMEOUT_CAP_SECONDS: Final[float] = 300.0
 
 

tests/test_transaction_fork_diagnostic.py

@@ -40,10 +40,12 @@ async def test_transaction_after_fork_raises_fork_diagnostic_not_cross_task() ->
     fake_parent_pid = conn._creator_pid + 1
     conn._creator_pid = fake_parent_pid
 
-    with patch("dqliteclient.connection.os.getpid", return_value=fake_parent_pid + 1):
-        with pytest.raises(InterfaceError, match="fork") as excinfo:
-            async with conn.transaction():
-                pass
+    with (
+        patch("dqliteclient.connection.os.getpid", return_value=fake_parent_pid + 1),
+        pytest.raises(InterfaceError, match="fork") as excinfo,
+    ):
+        async with conn.transaction():
+            pass
 
     # The diagnostic must be the fork message, not the cross-task one.
     msg = str(excinfo.value)