Skip to content

Commit 5c4f538

Browse files
Cycles 19-20: drop stale issue/PR cross-references, prune unused yaml extra
- Strip 'see #148' and 'see #080' references in cluster.py / pool.py — internal tracker numbers don't age well and don't help readers outside the original context. Rewrote the surrounding comments to carry the relevant information inline. - Drop the unused 'yaml' optional-dependency (pyyaml was never imported anywhere). If YAML cluster-config parsing lands later it can be re-added with the importing code in the same change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 906fe91 commit 5c4f538

File tree

4 files changed

+7
-48
lines changed

4 files changed

+7
-48
lines changed

pyproject.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ Issues = "https://github.com/letsdiscodev/python-dqlite-client/issues"
3535

3636
[project.optional-dependencies]
3737
dev = ["pytest>=8.0", "pytest-cov>=4.0", "pytest-asyncio>=0.23", "mypy>=1.0", "ruff>=0.4"]
38-
yaml = ["pyyaml>=6.0"]
3938

4039
[tool.hatch.build.targets.wheel]
4140
packages = ["src/dqliteclient"]

src/dqliteclient/cluster.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -171,10 +171,10 @@ async def try_connect() -> DqliteConnection:
171171
return conn
172172

173173
# Retry only transport-level errors. Leader-change OperationalError
174-
# codes are now reclassified into DqliteConnectionError at connect
175-
# time (see #148), so we no longer need OperationalError in the
176-
# retry set — that avoids amplifying a schema/SQL error into 5 ×
177-
# N_nodes RTTs before propagating.
174+
# codes are reclassified into DqliteConnectionError inside
175+
# DqliteConnection.connect(), so we no longer need OperationalError
176+
# in the retry set — that avoids amplifying a schema/SQL error
177+
# into 5 × N_nodes RTTs before propagating.
178178
return await retry_with_backoff(
179179
try_connect,
180180
max_attempts=3,

src/dqliteclient/pool.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -366,8 +366,8 @@ async def close(self) -> None:
366366

367367
# In-use connections are closed by acquire()'s cleanup when they
368368
# return — the else branch checks _closed and closes instead of
369-
# returning to the pool. Force-closing them here would race with
370-
# the acquire context manager and corrupt _size (see #080).
369+
# returning to the pool. Force-closing them here would race with
370+
# the acquire context manager and corrupt _size.
371371

372372
async def __aenter__(self) -> "ConnectionPool":
373373
await self.initialize()

uv.lock

Lines changed: 1 addition & 41 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)