Skip to content

Commit 61a4778

Browse files
Drop stale internal markers from cluster/exceptions/pool comments
Three comments cited internal review markers (cycle numbers, retired issue numbers) as cross-references. The markers go stale instantly — cycle counters are internal review concepts and issue numbers get reused after triage moves files. Replace each with the engineering rationale itself ("symmetric with the pid guards", "verbatim server text contract", "the prior _size accounting fix"). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 043dfe2 commit 61a4778

3 files changed

Lines changed: 9 additions & 9 deletions

File tree

src/dqliteclient/cluster.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ def __init__(
170170
# would observe an inherited task and ``await
171171
# asyncio.shield(<parent-loop task>)`` — undefined behaviour.
172172
# Symmetric with the DqliteConnection / ConnectionPool
173-
# pid guards added in cycle 20.
173+
# pid guards.
174174
self._creator_pid = os.getpid()
175175

176176
@classmethod

src/dqliteclient/exceptions.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,10 +101,10 @@ def __init__(
101101
# un-suffixed). Callers compose the display ``message`` with
102102
# peer-address suffix / "Failed to connect:" prefix etc. and
103103
# pass the unadorned server text as ``raw_message=`` so the
104-
# cycle-21 "raw_message is the bytes the server actually sent"
105-
# contract is preserved through the dbapi-layer plumbing. Old
106-
# call sites that omit the kwarg still get the previous
107-
# behaviour (``raw_message`` defaults to ``message``).
104+
# contract that raw_message is the verbatim server text is
105+
# preserved through the dbapi-layer plumbing. Old call sites
106+
# that omit the kwarg still get the previous behaviour
107+
# (``raw_message`` defaults to ``message``).
108108
self.raw_message = message if raw_message is None else raw_message
109109
if len(message) > self._MAX_DISPLAY_MESSAGE:
110110
# ``len(message)`` and the slice cap count Python codepoints,

src/dqliteclient/pool.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -385,10 +385,10 @@ async def initialize(self) -> None:
385385
# orphaned (transports leaked until GC).
386386
#
387387
# This is the symmetric resource-discipline fix to
388-
# the ``_size`` accounting fix (ISSUE-240) — that fix
389-
# moved the bookkeeping into the finally; the
390-
# connection-close sweep now does the same by
391-
# walking the explicit task list.
388+
# the prior ``_size`` accounting fix that moved the
389+
# bookkeeping into the finally; the connection-close
390+
# sweep now does the same by walking the explicit
391+
# task list.
392392
create_tasks: list[asyncio.Task[DqliteConnection]] = [
393393
asyncio.create_task(self._create_connection()) for _ in range(self._min_size)
394394
]

0 commit comments

Comments
 (0)