fix: use unsigned helper _u64 for BOOLEAN in golden-byte test

antoineleclair · claude · antoineleclair · commit 9782efbda3e5 · 2026-04-13T18:38:01.000-04:00
The golden-byte test used _i64(1) (signed int64) for BOOLEAN True, but
the production code uses encode_uint64 (unsigned). The wire bytes are
identical for value 1, but using _u64 correctly documents the encoding.

Closes #144

Co-Authored-By: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/tests/test_golden_bytes.py b/tests/test_golden_bytes.py
@@ -222,7 +222,7 @@ def test_rows_response_boolean_nibble(self) -> None:
             + _u64(1)  # column_count
             + _text("flag")
             + row_header
-            + _i64(1)  # BOOLEAN True encoded as int64(1)
+            + _u64(1)  # BOOLEAN True encoded as uint64(1)
             + done_marker
         )
 

Original file line number	Diff line number	Diff line change
`@@ -222,7 +222,7 @@ def test_rows_response_boolean_nibble(self) -> None:`
`222`	`222`	`+ _u64(1) # column_count`
`223`	`223`	`+ _text("flag")`
`224`	`224`	`+ row_header`
`225`		`- + _i64(1) # BOOLEAN True encoded as int64(1)`
	`225`	`+ + _u64(1) # BOOLEAN True encoded as uint64(1)`
`226`	`226`	`+ done_marker`
`227`	`227`	`)`
`228`	`228`