Commit 1452410
Pin do_ping cursor-close suppression branches
do_ping's finally narrowly suppresses cursor.close failures on
OperationalError, InterfaceError, DqliteConnectionError, OSError,
and TimeoutError so a dead-socket close does not crash the probe,
while letting programming bugs (ValueError, TypeError, ...)
propagate. Tests covered DqliteConnectionError and the
ValueError-propagates inverse, but OperationalError,
InterfaceError, OSError, BrokenPipeError, and TimeoutError had no
direct pin. A refactor dropping any OS-level type would silently
re-raise legitimate close-path transport errors and break pool
pre-ping.
Parametrize across the full suppression tuple; each case asserts
do_ping returns True (execute succeeded) and the close failure
produces the DEBUG log line carrying the exception type.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 88ae813 commit 1452410
1 file changed
Lines changed: 31 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
104 | 104 | | |
105 | 105 | | |
106 | 106 | | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
0 commit comments