Commit 2d28ceb
Pin the four insert-path dialect flags against upstream drift
SQLAlchemy's SQLiteDialect explicitly overrides four insert-path
flags that DefaultDialect sets to False: use_insertmanyvalues,
supports_default_metavalue, supports_default_values, and
insert_null_pk_still_autoincrements. The dqlite dialect inherited
them silently, so a version-gated change in a future SQLAlchemy
release could alter insert codegen, DEFAULT VALUES handling, or
rowid autoincrement behaviour without any signal on our side.
Declare all four locally in DqliteDialect with a comment block that
ties them back to the RETURNING and multivalues_insert pins already
present, and extend the parametrised pin test so re-inheritance
would fail the pin-tests immediately.
None of these flips observable behaviour today — the pinned values
match what SQLiteDialect already sets — this is documentation-as-
code plus a forward-compatibility guard.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 0019631 commit 2d28ceb
2 files changed
Lines changed: 30 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
120 | 120 | | |
121 | 121 | | |
122 | 122 | | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
123 | 134 | | |
124 | 135 | | |
125 | 136 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
3 | 4 | | |
4 | 5 | | |
5 | 6 | | |
| |||
85 | 86 | | |
86 | 87 | | |
87 | 88 | | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
88 | 107 | | |
89 | 108 | | |
90 | 109 | | |
| |||
0 commit comments