Skip to content

Commit 3833a18

Browse files
Strip internal issue-tracker references from tests and comments
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 7501d70 commit 3833a18

11 files changed

Lines changed: 24 additions & 25 deletions

src/sqlalchemydqlite/aio.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,8 +135,8 @@ def rollback(self) -> None:
135135

136136
def close(self) -> None:
137137
# Attempt rollback before close so a caller that exits without
138-
# committing does not leave a dangling server-side transaction
139-
# (ISSUE-91). The underlying async connection's rollback is a
138+
# committing does not leave a dangling server-side transaction.
139+
# The underlying async connection's rollback is a
140140
# silent no-op when no transaction is active and when the
141141
# connection has never been used, so the double-call is safe.
142142
# Suppress rollback failures — the close is more important and

src/sqlalchemydqlite/base.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ class _DqliteDateTime(sqltypes.DateTime):
2525
deliberate: the generic parent's ``literal_processor`` calls
2626
``value.isoformat()`` directly — bypassing pysqlite's
2727
iso-string-based bind processor that would double-convert our
28-
already-datetime values (ISSUE-114). The parent's default
28+
already-datetime values. The parent's default
2929
``bind_processor`` / ``result_processor`` return ``None`` already,
3030
so no explicit overrides are needed here.
3131
"""

tests/integration/test_async_executemany.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
"""Integration tests for async-dialect executemany (ISSUE-92).
1+
"""Integration tests for async-dialect executemany.
22
33
Pins ``AsyncAdaptedCursor.executemany`` against a real dqlite server:
44

tests/integration/test_date_tz_drop.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
"""Lock in _DqliteDate UTC-day semantics for tz-aware inputs (ISSUE-56).
1+
"""Lock in _DqliteDate UTC-day semantics for tz-aware inputs.
22
33
The _DqliteDate result processor narrows datetime→date via ``.date()``.
44
If the decoded datetime was timezone-aware, the tzinfo is silently

tests/integration/test_native_boolean.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
"""Integration tests for ISSUE-44: supports_native_boolean = True.
1+
"""Integration tests for supports_native_boolean = True.
22
33
DDL for ``Column(Boolean)`` must not emit ``CHECK (col IN (0, 1))``
44
because dqlite's wire protocol enforces the invariant natively.

tests/integration/test_reflect_column_types.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
"""Lock in reflected column type-class identity (ISSUE-45).
1+
"""Lock in reflected column type-class identity.
22
33
ischema_names inherited from pysqlite covers the tokens dqlite emits
44
at DDL time (INTEGER, TEXT, REAL, BLOB, NUMERIC, DATE, DATETIME, ...).

tests/integration/test_time_and_reflection.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
"""Coverage for Time columns (ISSUE-20) and metadata reflection (ISSUE-22).
1+
"""Coverage for Time columns and metadata reflection.
22
3-
- ISSUE-20: ``Column(Time)`` is not overridden in the dialect's
3+
- ``Column(Time)`` is not overridden in the dialect's
44
``colspecs`` because the C server tags only DATETIME/DATE/TIMESTAMP
55
as ``DQLITE_ISO8601``; TIME columns come back as plain TEXT and the
66
inherited SQLAlchemy ``Time`` processor parses the string. Verified
77
here end-to-end.
88
9-
- ISSUE-22: the dialect inherits SQLite's reflection methods, which
9+
- The dialect inherits SQLite's reflection methods, which
1010
lean on PRAGMA queries. dqlite wraps SQLite but we had zero proof
1111
that reflection round-trips over the wire. These tests exercise the
1212
common paths.

tests/test_adapter_stale_rows.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
"""ISSUE-37: AsyncAdaptedCursor must not leak rows from a previous
1+
"""AsyncAdaptedCursor must not leak rows from a previous
22
execute across an exception (including CancelledError)."""
33

44
import asyncio

tests/test_async_adapter.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ def test_executemany_cursor_closed_on_error(self) -> None:
104104

105105

106106
class TestAsyncAdaptedConnectionClose:
107-
"""ISSUE-91: close() attempts rollback before closing.
107+
"""close() attempts rollback before closing.
108108
109109
SQLAlchemy's async adapter previously closed the connection without
110110
a rollback, leaving any open server-side transaction dangling in

tests/test_dialect.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,21 +46,20 @@ def test_create_connect_args_custom(self) -> None:
4646

4747
def test_supports_sane_isolation_level(self) -> None:
4848
# dqlite always enforces SERIALIZABLE; the reported level is
49-
# trustworthy across transactions (ISSUE-90).
49+
# trustworthy across transactions.
5050
assert DqliteDialect.supports_sane_isolation_level is True
5151

5252
def test_supports_native_decimal_false(self) -> None:
53-
# SQLite/dqlite has no native DECIMAL type (ISSUE-94).
53+
# SQLite/dqlite has no native DECIMAL type.
5454
assert DqliteDialect.supports_native_decimal is False
5555

5656
def test_dialect_description(self) -> None:
5757
# Pin the derived dialect_description so SQLAlchemy upgrades cannot
58-
# silently change the rendered identity in ORM error messages
59-
# (ISSUE-89).
58+
# silently change the rendered identity in ORM error messages.
6059
assert DqliteDialect().dialect_description == "dqlite+dqlitedbapi"
6160

6261
def test_async_dialect_description(self) -> None:
63-
# Mirror ISSUE-89 pin for the async dialect; review agent flagged
62+
# Mirror the sync test for the async dialect; review agent flagged
6463
# that the sync test alone could mask an async-side drift.
6564
assert DqliteDialect_aio().dialect_description == "dqlite+dqlitedbapi_aio"
6665

0 commit comments

Comments
 (0)