Remove duplicate methods from async dialect

DqliteDialect_aio needlessly overrode create_connect_args, do_rollback,
do_commit, and _get_server_version_info with identical copies from the
base DqliteDialect. Remove them so the async dialect inherits instead.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: antoineleclair

src/sqlalchemydqlite/aio.py

@@ -6,7 +6,6 @@
 
 from sqlalchemy import pool
 from sqlalchemy.engine import URL, AdaptedConnection
-from sqlalchemy.engine.interfaces import DBAPIConnection
 from sqlalchemy.pool import AsyncAdaptedQueuePool
 from sqlalchemy.util import await_only
 
@@ -146,50 +145,6 @@ def connect(self, *cargs: Any, **cparams: Any) -> Any:
         raw_conn = self.loaded_dbapi.connect(*cargs, **cparams)
         return AsyncAdaptedConnection(raw_conn)
 
-    def create_connect_args(self, url: URL) -> tuple[list[Any], dict[str, Any]]:
-        """Create connection arguments from URL.
-
-        URL format: dqlite+aio://host:port/database
-        """
-        host = url.host or "localhost"
-        port = url.port or 9001
-        database = url.database or "default"
-
-        address = f"{host}:{port}"
-
-        return [], {
-            "address": address,
-            "database": database,
-        }
-
-    def do_rollback(self, dbapi_connection: DBAPIConnection) -> None:
-        """Rollback the current transaction."""
-        try:
-            dbapi_connection.rollback()
-        except Exception as e:
-            if "no transaction is active" not in str(e):
-                raise
-
-    def do_commit(self, dbapi_connection: DBAPIConnection) -> None:
-        """Commit the current transaction."""
-        try:
-            dbapi_connection.commit()
-        except Exception as e:
-            if "no transaction is active" not in str(e):
-                raise
-
-    def _get_server_version_info(self, connection: Any) -> tuple[int, ...]:
-        """Return the server version as a tuple."""
-        cursor = connection.connection.dbapi_connection.cursor()
-        cursor.execute("SELECT sqlite_version()")
-        row = cursor.fetchone()
-        cursor.close()
-
-        if row:
-            version_str = row[0]
-            return tuple(int(x) for x in version_str.split("."))
-        return (3, 0, 0)
-
     def get_driver_connection(self, connection: Any) -> Any:
         """Return the driver-level connection."""
         return connection

tests/test_dialect.py

@@ -54,6 +54,21 @@ def test_dialect_is_async(self) -> None:
         dialect = DqliteDialect_aio()
         assert dialect.is_async is True
 
+    def test_inherits_shared_methods_from_base(self) -> None:
+        """Async dialect should inherit shared methods from base, not duplicate them."""
+        shared_methods = [
+            "create_connect_args",
+            "do_rollback",
+            "do_commit",
+            "_get_server_version_info",
+        ]
+        for method_name in shared_methods:
+            base_method = getattr(DqliteDialect, method_name)
+            aio_method = getattr(DqliteDialect_aio, method_name)
+            assert base_method is aio_method, (
+                f"{method_name} is overridden in DqliteDialect_aio but should be inherited"
+            )
+
     def test_import_dbapi(self) -> None:
         dbapi = DqliteDialect_aio.import_dbapi()
         assert hasattr(dbapi, "aconnect")