Skip to content

Commit 67e762e

Browse files
simbabqueoalders
authored andcommitted
add tests for undef filenames
1 parent 69a7a3d commit 67e762e

2 files changed

Lines changed: 15 additions & 1 deletion

File tree

lib/HTML/Form.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1540,7 +1540,7 @@ sub form_name_value {
15401540
my @headers = $self->headers;
15411541
my $content = $self->content;
15421542
my %headers = @headers;
1543-
if (defined $content || grep m/^Content$/, keys %headers) {
1543+
if (defined $content || grep m/^Content$/i, keys %headers) {
15441544
$filename = $file unless defined $filename;
15451545
$file = undef;
15461546
unshift(@headers, "Content" => $content);

t/file_upload.t

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,12 @@ $input->file([ $file, $filename, Content => 'inline content' ]);
4949
like( $form->make_request->as_string, qr! filename="$filename" !x,
5050
q/Upload: using $input->file([$file, $filename, Content => '?'])/ );
5151

52+
# $input->file and array refs and undef
53+
($form, $input) = new_form_and_input;
54+
$input->file([ undef, $filename, Content => 'inline content' ]);
55+
like( $form->make_request->as_string, qr! filename="$filename" !x,
56+
q/Upload: using $input->file([undef, $filename, Content => '?'])/ );
57+
5258
# $form->value and array refs
5359
($form, $input) = new_form_and_input;
5460
$form->value('document', [ $file, $filename, Content => 'inline content' ]);
@@ -78,4 +84,12 @@ $input->content('inline content');
7884
like( $form->make_request->as_string, qr! filename="$filename" !x,
7985
"Upload: 'file', 'filename' and 'content' informed directly" );
8086

87+
88+
# undef, 'filename' and 'content' informed directly
89+
($form, $input) = new_form_and_input;
90+
$input->filename($filename);
91+
$input->content('inline content');
92+
like( $form->make_request->as_string, qr! filename="$filename" !x,
93+
"Upload: undef, 'filename' and 'content' informed directly" );
94+
8195
done_testing;

0 commit comments

Comments
 (0)