Merge pull request #33 from libwww-perl/simbabque/old-pr-8

Resubmit PR for #8 (old #7)

Author: simbabque

Changes

@@ -2,6 +2,7 @@ Change history for HTML-Form
 
 {{$NEXT}}
     - Remove Authority section from dist.ini (GH#27) (Olaf Alders)
+    - Allow buttons to not have a value (GH#8) (Felix Ostmann and Julien Fiegehenn)
 
 6.07      2020-02-21 03:50:52Z
     - Restore =head1 NAME section to pod for HTML::Form

lib/HTML/Form.pm

@@ -1419,6 +1419,7 @@ sub click
     my($self,$form,$x,$y) = @_;
     for ($x, $y) { $_ = 1 unless defined; }
     local($self->{clicked}) = [$x,$y];
+    local($self->{value})   = "" unless defined $self->value;
     return $form->make_request;
 }
 

t/form.t

@@ -3,7 +3,7 @@
 use strict;
 use Test qw(plan ok);
 
-plan tests => 127;
+plan tests => 129;
 
 use HTML::Form;
 
@@ -595,3 +595,33 @@ $f = HTML::Form->parse(<<EOT, "http://www.example.com");
 </form>
 EOT
 ok(@warn, 0);
+
+$f = HTML::Form->parse(<<EOT, base => "http://localhost/");
+<form method=post>
+<form action="test" method="post">
+<button type="submit" name="submit" value="go">run</button>
+</form>
+EOT
+
+ok($f->click->as_string, <<EOT);
+POST http://localhost/
+Content-Length: 9
+Content-Type: application/x-www-form-urlencoded
+
+submit=go
+EOT
+
+$f = HTML::Form->parse(<<EOT, base => "http://localhost/");
+<form method=post>
+<form action="test" method="post">
+<button type="submit" name="submit">run</button>
+</form>
+EOT
+
+ok($f->click->as_string, <<EOT);
+POST http://localhost/
+Content-Length: 7
+Content-Type: application/x-www-form-urlencoded
+
+submit=
+EOT