From 082f2ad7ca1f22471867078ccd677dad713017cd Mon Sep 17 00:00:00 2001 From: Fabian Blechschmidt Date: Thu, 14 Nov 2019 16:31:07 +0100 Subject: [PATCH] Add coupon redemption error headline --- .../Hackathon/PromoCodeMessages/Model/Observer.php | 11 +++++++++-- src/app/locale/de_DE/Hackathon_PromoCodeMessages.csv | 1 + src/app/locale/en_US/Hackathon_PromoCodeMessages.csv | 5 +++-- 3 files changed, 13 insertions(+), 4 deletions(-) diff --git a/src/app/code/community/Hackathon/PromoCodeMessages/Model/Observer.php b/src/app/code/community/Hackathon/PromoCodeMessages/Model/Observer.php index fdf132e..ebbc791 100644 --- a/src/app/code/community/Hackathon/PromoCodeMessages/Model/Observer.php +++ b/src/app/code/community/Hackathon/PromoCodeMessages/Model/Observer.php @@ -40,13 +40,20 @@ public function validateCode(Varien_Event_Observer $observer) return; } - $quote = $observer->getQuote(); + $quote = $observer->getQuote(); $couponCode = $quote->getCouponCode(); if (!$couponCode || $couponCode == '') { // parent validation has failed $couponCode = (string)Mage::app()->getRequest()->getParam('coupon_code'); - Mage::getModel('hackathon_promocodemessages/validator')->validate($couponCode, $quote); + try { + Mage::getModel('hackathon_promocodemessages/validator')->validate($couponCode, $quote); + } catch (Mage_Core_Exception $e) { + $msg = Mage::helper('hackathon_promocodemessages')->__('Your coupon could not be redeemed.'); + $msg = "

$msg

"; + $msg .= $e->getMessage(); + throw new Mage_Core_Exception($msg, 0, $e); + } } } } diff --git a/src/app/locale/de_DE/Hackathon_PromoCodeMessages.csv b/src/app/locale/de_DE/Hackathon_PromoCodeMessages.csv index 27c3c13..789efe0 100644 --- a/src/app/locale/de_DE/Hackathon_PromoCodeMessages.csv +++ b/src/app/locale/de_DE/Hackathon_PromoCodeMessages.csv @@ -30,3 +30,4 @@ "Your coupon is not valid for your Customer Group.","Der Gutschein ist für Ihre Kundengruppe nicht freigeschaltet." "Your coupon is not valid yet. It will be active on %s.","Der Gutschein ist noch nicht aktiv. Er wird am %s freigeschaltet." "Your coupon was already used.","Ihr Gutschein wurde bereits benutzt." +"Your coupon could not be redeemed.","Ihr Gutschein konnte nicht eingelöst werden." diff --git a/src/app/locale/en_US/Hackathon_PromoCodeMessages.csv b/src/app/locale/en_US/Hackathon_PromoCodeMessages.csv index 967bf53..179d12b 100644 --- a/src/app/locale/en_US/Hackathon_PromoCodeMessages.csv +++ b/src/app/locale/en_US/Hackathon_PromoCodeMessages.csv @@ -28,5 +28,6 @@ "This will give customers further information on what exactly has failed with their coupon code.","This will give customers further information on what exactly has failed with their coupon code." "Validate cart rule conditions","Validate cart rule conditions" "Validate cart rule actions","Validate cart rule actions" -"Provides error messaging for conditions under \"Conditions\" tab","Provides error messaging for conditions under \"Conditions\" tab" -"Provides error messaging for actions under \"Actions\" tab","Provides error messaging for actions under \"Actions\" tab" +"Provides error messaging for conditions under ""Conditions"" tab","Provides error messaging for conditions under ""Conditions"" tab" +"Provides error messaging for actions under ""Actions"" tab","Provides error messaging for actions under ""Actions"" tab" +"Your coupon could not be redeemed.","Your coupon could not be redeemed."