Skip to content

Commit 03ef646

Browse files
Addresses mentor feedback
1 parent adf2242 commit 03ef646

4 files changed

Lines changed: 227 additions & 114 deletions

File tree

malariagen_data/ag3.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55
import plotly.express as px # type: ignore
66
import malariagen_data
77
from .anopheles import AnophelesDataResource
8-
from .anoph.phenotypes import PhenotypeDataMixin
9-
108

119
# silence dask performance warnings
1210
dask.config.set(**{"array.slicing.split_native_chunks": False}) # type: ignore
@@ -78,7 +76,7 @@ def _setup_aim_palettes():
7876
}
7977

8078

81-
class Ag3(AnophelesDataResource, PhenotypeDataMixin):
79+
class Ag3(AnophelesDataResource):
8280
"""Provides access to data from Ag3.x releases.
8381
8482
Parameters
@@ -135,7 +133,6 @@ class Ag3(AnophelesDataResource, PhenotypeDataMixin):
135133

136134
_xpehh_gwss_cache_name = XPEHH_GWSS_CACHE_NAME
137135
_ihs_gwss_cache_name = IHS_GWSS_CACHE_NAME
138-
_phenotype_gcs_path_template = "gs://vo_agam_release_master_us_central1/v3.2/phenotypes/all/{sample_set}/phenotypes.csv"
139136

140137
def __init__(
141138
self,
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
"""
2+
Type aliases for phenotype-related parameters.
3+
"""
4+
from typing import TypeAlias, Optional, Union, List
5+
6+
# Type alias for insecticide parameter
7+
insecticide: TypeAlias = Optional[Union[str, List[str]]]
8+
9+
# Type alias for dose parameter
10+
dose: TypeAlias = Optional[Union[float, List[float]]]
11+
12+
# Type alias for phenotype parameter
13+
phenotype: TypeAlias = Optional[Union[str, List[str]]]

0 commit comments

Comments
 (0)