Merge pull request #980 from suhr25/fix/invalid-param-error-messages

jonbrenas · web-flow · commit 1b2ef11e09e0 · 2026-03-01T15:14:02.000Z
Fix: remove stray `f` in ValueError messages
diff --git a/malariagen_data/anoph/hap_data.py b/malariagen_data/anoph/hap_data.py
@@ -64,7 +64,7 @@ def _prep_phasing_analysis_param(self, *, analysis: hap_params.analysis) -> str:
             return analysis
         else:
             raise ValueError(
-                f"Invalid phasing analysis, must be one of f{self.phasing_analysis_ids}."
+                f"Invalid phasing analysis, must be one of {self.phasing_analysis_ids}."
             )
 
     @_check_types
diff --git a/malariagen_data/anoph/snp_data.py b/malariagen_data/anoph/snp_data.py
@@ -116,9 +116,7 @@ def _prep_site_mask_param(
         elif site_mask in self.site_mask_ids:
             return site_mask
         else:
-            raise ValueError(
-                f"Invalid site mask, must be one of f{self.site_mask_ids}."
-            )
+            raise ValueError(f"Invalid site mask, must be one of {self.site_mask_ids}.")
 
     def _prep_optional_site_mask_param(
         self,

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ def _prep_phasing_analysis_param(self, *, analysis: hap_params.analysis) -> str:`
`64`	`64`	`return analysis`
`65`	`65`	`else:`
`66`	`66`	`raise ValueError(`
`67`		`- f"Invalid phasing analysis, must be one of f{self.phasing_analysis_ids}."`
	`67`	`+ f"Invalid phasing analysis, must be one of {self.phasing_analysis_ids}."`
`68`	`68`	`)`
`69`	`69`
`70`	`70`	`@_check_types`