Skip to content

Commit 23e2e7c

Browse files
committed
Use raise from when re-wrapping exceptions in base.py to provide better traceback (Pylint raise-missing-from)
1 parent 67ffa47 commit 23e2e7c

1 file changed

Lines changed: 10 additions & 8 deletions

File tree

malariagen_data/anoph/base.py

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -778,10 +778,10 @@ def lookup_release(self, sample_set: base_params.sample_set) -> str:
778778

779779
try:
780780
return self._cache_sample_set_to_release[sample_set]
781-
except KeyError:
781+
except KeyError as e:
782782
raise ValueError(
783783
f"No release found for sample set {sample_set!r}. This sample set might be unavailable or irrelevant with respect to settings."
784-
)
784+
) from e
785785

786786
@check_types
787787
@doc(
@@ -794,8 +794,8 @@ def lookup_study(self, sample_set: base_params.sample_set) -> str:
794794
self._cache_sample_set_to_study = df_sample_sets["study_id"].to_dict()
795795
try:
796796
return self._cache_sample_set_to_study[sample_set]
797-
except KeyError:
798-
raise ValueError(f"No study ID found for sample set {sample_set!r}")
797+
except KeyError as e:
798+
raise ValueError(f"No study ID found for sample set {sample_set!r}") from e
799799

800800
@check_types
801801
@doc(
@@ -810,8 +810,10 @@ def lookup_study_info(self, sample_set: base_params.sample_set) -> dict:
810810
].to_dict(orient="index")
811811
try:
812812
return self._cache_sample_set_to_study_info[sample_set]
813-
except KeyError:
814-
raise ValueError(f"No study info found for sample set {sample_set!r}")
813+
except KeyError as e:
814+
raise ValueError(
815+
f"No study info found for sample set {sample_set!r}"
816+
) from e
815817

816818
@check_types
817819
@doc(
@@ -830,10 +832,10 @@ def lookup_terms_of_use_info(self, sample_set: base_params.sample_set) -> dict:
830832
].to_dict(orient="index")
831833
try:
832834
return self._cache_sample_set_to_terms_of_use_info[sample_set]
833-
except KeyError:
835+
except KeyError as e:
834836
raise ValueError(
835837
f"No terms-of-use info found for sample set {sample_set!r}"
836-
)
838+
) from e
837839

838840
def _prep_sample_sets_param(
839841
self, *, sample_sets: Optional[base_params.sample_sets]

0 commit comments

Comments
 (0)