Merge pull request #634 from malariagen/618-bad-random-value

Random error when performing tests

Author: leehart

tests/anoph/test_pca.py

@@ -96,7 +96,7 @@ def test_pca_plotting(fixture, api: AnophelesPca):
     n_snps = random.randint(4, n_snps_available)
     # PC3 required for plot_pca_coords_3d()
     assert min(n_samples, n_snps) > 3
-    n_components = random.randint(3, min(n_samples, n_snps))
+    n_components = random.randint(3, min(n_samples, n_snps, 10))
 
     # Run the PCA.
     pca_df, pca_evr = api.pca(
@@ -184,7 +184,7 @@ def test_pca_exclude_samples(fixture, api: AnophelesPca):
     # PCA parameters.
     n_samples = ds.sizes["samples"] - n_samples_excluded
     n_snps_available = ds.sizes["variants"]
-    n_snps = random.randint(1, n_snps_available)
+    n_snps = random.randint(4, n_snps_available)
     n_components = random.randint(2, min(n_samples, n_snps, 10))
 
     # Run the PCA.
@@ -245,7 +245,7 @@ def test_pca_fit_exclude_samples(fixture, api: AnophelesPca):
     # PCA parameters.
     n_samples = ds.sizes["samples"]
     n_snps_available = ds.sizes["variants"]
-    n_snps = random.randint(1, n_snps_available)
+    n_snps = random.randint(4, n_snps_available)
     n_components = random.randint(2, min(n_samples, n_snps, 10))
 
     # Run the PCA.