Merge pull request #1034 from suhaan-24/fix/veff-replace-asserts-with-exceptions

fix: replace bare asserts in veff.py with explicit ValueError exceptions

Author: jonbrenas

malariagen_data/veff.py

@@ -92,10 +92,12 @@ def get_ref_allele_coords(self, chrom, pos, ref):
 
         # check the reference allele matches the reference sequence
         ref_seq = self.get_ref_seq(chrom, ref_start, ref_stop).lower()
-        assert ref_seq == ref.lower(), (
-            "reference allele does not match reference sequence, "
-            f"expected {ref_seq!r}, found {ref.lower()!r}"
-        )
+        if ref_seq != ref.lower():
+            raise ValueError(
+                f"Reference allele does not match reference sequence at "
+                f"{chrom}:{ref_start}-{ref_stop}. Expected {ref_seq!r}, "
+                f"found {ref.lower()!r}."
+            )
 
         return ref_start, ref_stop
 
@@ -170,7 +172,12 @@ def get_effects(self, transcript, variants, progress=None):
             )
 
             # reference allele falls within current transcript
-            assert feature_start <= ref_start <= ref_stop <= feature_stop
+            if not (feature_start <= ref_start <= ref_stop <= feature_stop):
+                raise ValueError(
+                    f"Variant coordinates ({ref_start}-{ref_stop}) fall outside "
+                    f"transcript boundaries ({feature_start}-{feature_stop}) "
+                    f"on {chrom}."
+                )
 
             effect = _get_within_transcript_effect(
                 ann=self,
@@ -276,7 +283,11 @@ def _get_cds_effect(ann, base_effect, cds, cdss):
     cds_stop = cds.end
 
     # reference allele falls within current transcript
-    assert cds_start <= ref_start <= ref_stop <= cds_stop
+    if not (cds_start <= ref_start <= ref_stop <= cds_stop):
+        raise ValueError(
+            f"Variant coordinates ({ref_start}-{ref_stop}) fall outside "
+            f"CDS boundaries ({cds_start}-{cds_stop})."
+        )
     return _get_within_cds_effect(ann, base_effect, cds, cdss)