Skip to content

Commit d7bdf74

Browse files
committed
Fix linting issues in util.py and test_util.py (ruff format)
1 parent 7e0a05b commit d7bdf74

2 files changed

Lines changed: 10 additions & 31 deletions

File tree

malariagen_data/util.py

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1524,12 +1524,10 @@ def _apply_allele_mapping(x, mapping, max_allele):
15241524

15251525
def _dask_apply_allele_mapping(v, mapping, max_allele):
15261526
if not isinstance(v, da.Array):
1527-
raise TypeError(
1528-
f"Expected v to be a dask.array.Array, " f"got {type(v).__name__}"
1529-
)
1527+
raise TypeError(f"Expected v to be a dask.array.Array, got {type(v).__name__}")
15301528
if not isinstance(mapping, np.ndarray):
15311529
raise TypeError(
1532-
f"Expected mapping to be a numpy.ndarray, " f"got {type(mapping).__name__}"
1530+
f"Expected mapping to be a numpy.ndarray, got {type(mapping).__name__}"
15331531
)
15341532
assert v.ndim == 2
15351533
assert mapping.ndim == 2
@@ -1551,12 +1549,10 @@ def _genotype_array_map_alleles(gt, mapping):
15511549
# N.B., scikit-allel does not handle empty blocks well, so we
15521550
# include some extra logic to handle that better.
15531551
if not isinstance(gt, np.ndarray):
1554-
raise TypeError(
1555-
f"Expected gt to be a numpy.ndarray, " f"got {type(gt).__name__}"
1556-
)
1552+
raise TypeError(f"Expected gt to be a numpy.ndarray, got {type(gt).__name__}")
15571553
if not isinstance(mapping, np.ndarray):
15581554
raise TypeError(
1559-
f"Expected mapping to be a numpy.ndarray, " f"got {type(mapping).__name__}"
1555+
f"Expected mapping to be a numpy.ndarray, got {type(mapping).__name__}"
15601556
)
15611557
assert gt.ndim == 3
15621558
assert mapping.ndim == 3
@@ -1578,11 +1574,11 @@ def _genotype_array_map_alleles(gt, mapping):
15781574
def _dask_genotype_array_map_alleles(gt, mapping):
15791575
if not isinstance(gt, da.Array):
15801576
raise TypeError(
1581-
f"Expected gt to be a dask.array.Array, " f"got {type(gt).__name__}"
1577+
f"Expected gt to be a dask.array.Array, got {type(gt).__name__}"
15821578
)
15831579
if not isinstance(mapping, np.ndarray):
15841580
raise TypeError(
1585-
f"Expected mapping to be a numpy.ndarray, " f"got {type(mapping).__name__}"
1581+
f"Expected mapping to be a numpy.ndarray, got {type(mapping).__name__}"
15861582
)
15871583
assert gt.ndim == 3
15881584
assert mapping.ndim == 2

tests/test_util.py

Lines changed: 4 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,15 @@
11
"""Tests for Region.__repr__ and CacheMiss.__repr__ / default message."""
2-
import importlib.util as ilu
3-
import sys
42

5-
# Load malariagen_data/util.py directly, bypassing the package __init__.py
6-
# which has heavy transitive imports (bokeh, plotly, etc.).
7-
_spec = ilu.spec_from_file_location(
8-
"malariagen_data.util",
9-
"malariagen_data/util.py",
10-
)
11-
_util = ilu.module_from_spec(_spec)
12-
sys.modules["malariagen_data.util"] = _util
3+
import pytest
134

14-
try:
15-
_spec.loader.exec_module(_util)
16-
except Exception:
17-
# If util.py itself can't be loaded (missing deps), fall back to a
18-
# normal import so the tests still work in a fully-installed env.
19-
import malariagen_data.util as _util # type: ignore[assignment]
20-
21-
Region = _util.Region
22-
CacheMiss = _util.CacheMiss
23-
24-
import pytest # noqa: E402
5+
from malariagen_data.util import CacheMiss, Region
256

267

278
# ---------------------------------------------------------------------------
289
# Region
2910
# ---------------------------------------------------------------------------
3011

12+
3113
def test_region_repr_contig_only():
3214
r = Region("2L")
3315
assert repr(r) == "Region('2L', None, None)"
@@ -55,6 +37,7 @@ def test_region_repr_start_only():
5537
# CacheMiss
5638
# ---------------------------------------------------------------------------
5739

40+
5841
def test_cache_miss_no_key():
5942
cm = CacheMiss()
6043
assert repr(cm) == "CacheMiss()"

0 commit comments

Comments
 (0)