Commit dbc4f46
committed
Surface ipinfo.io location check failures
Closes #1311.
The ipinfo.io lookup in AnophelesBase swallowed every OSError silently,
leaving _client_details = None. That cascaded into _get_gcp_region()
returning None and the GCS URL optimisation falling back to the default
bucket without any indication that the location check had failed.
Researchers on restricted networks (corporate firewalls, institutional
VPNs, regions where ipinfo.io is blocked) hit this path the most, and
had no way to correlate slow downloads with a failed lookup.
Now the failure is logged at DEBUG level for users running with
debug=True, and a UserWarning is emitted explaining the fallback and
pointing to the `url` parameter as a manual override. The fallback
behaviour itself is unchanged.1 parent 9c1bb56 commit dbc4f46
1 file changed
+10
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
103 | 103 | | |
104 | 104 | | |
105 | 105 | | |
106 | | - | |
107 | | - | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
108 | 116 | | |
109 | 117 | | |
110 | 118 | | |
| |||
0 commit comments