Skip to content

Commit f83d7a1

Browse files
committed
style: fix ruff formatting in util.py and test_base.py
Signed-off-by: suhr25 <suhridmarwah07@gmail.com>
1 parent e94fd5d commit f83d7a1

2 files changed

Lines changed: 10 additions & 6 deletions

File tree

malariagen_data/util.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -855,9 +855,7 @@ def _value_error(
855855
value,
856856
expectation,
857857
):
858-
message = (
859-
f"Bad value for parameter {name}; expected {expectation}, " f"found {value!r}"
860-
)
858+
message = f"Bad value for parameter {name}; expected {expectation}, found {value!r}"
861859
raise ValueError(message)
862860

863861

@@ -899,6 +897,12 @@ def __init__(
899897
handler = logging.FileHandler(out)
900898
self._handler = handler
901899

900+
# Remove any pre-existing handlers from the singleton logger to prevent
901+
# accumulation (and FileHandler FD leaks) on repeated instantiation.
902+
for existing_handler in logger.handlers[:]:
903+
logger.removeHandler(existing_handler)
904+
existing_handler.close()
905+
902906
# configure handler
903907
if handler is not None:
904908
if debug:

tests/anoph/test_base.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -298,9 +298,9 @@ def test_logging_helper_set_level_updates_logger():
298298
helper.set_level(logging.DEBUG)
299299
helper.debug("should appear")
300300
output = out.getvalue()
301-
assert "should appear" in output, (
302-
"set_level(DEBUG) had no effect: debug message was silently dropped"
303-
)
301+
assert (
302+
"should appear" in output
303+
), "set_level(DEBUG) had no effect: debug message was silently dropped"
304304

305305

306306
def _strip_terms_of_use_from_manifest(manifest_path):

0 commit comments

Comments
 (0)