Merge pull request #18 from marcbachmann/phantom-path

Phantom path

Author: marcbachmann

Changelog.md

@@ -1,3 +1,8 @@
+1.1.0
+=====
+- From now on options.phantomPath allows you to overwrite the default PhantomJS binary path.
+
+
 1.0.0
 =====
 - Catch phantomjs errors [517d307](https://github.com/marcbachmann/node-html-pdf/commit/517d30762e3121f72aa3879e07f5944c05c4d96d)

README.md

@@ -81,8 +81,9 @@ config = {
   "quality": "75",           // only used for types png & jpeg
 
   // Script options
-  "script": '/url'           // Absolute path to a custom phantomjs script, use the file in lib/scripts as example
-  "timeout": 10000           // Timeout that will cancel phantomjs, in milliseconds
+  "phantomPath": "./node_modules/phantomjs/bin/phantomjs", // PhantomJS binary which should get downloaded automatically
+  "script": '/url',           // Absolute path to a custom phantomjs script, use the file in lib/scripts as example
+  "timeout": 30000           // Timeout that will cancel phantomjs, in milliseconds
 
 }
 ```

lib/index.js

@@ -1,6 +1,6 @@
 {
   "name": "html-pdf",
-  "version": "1.0.0",
+  "version": "1.1.0",
   "description": "HTML to PDF converter that uses phantomjs",
   "main": "lib/index.js",
   "directories": {
@@ -16,7 +16,7 @@
     "tape": "^3.4.0",
     "tap-spec": "^2.2.0"
   },
-  "dependencies": {
+  "optionalDependencies": {
     "phantomjs": "^1.9.8"
   },
   "repository": {

lib/pdf.js

@@ -3,7 +3,11 @@ Stream = require('stream').Readable
 childprocess = require('child_process')
 path = require('path')
 assert = require('assert')
-phantomjs = require('phantomjs')
+
+try
+  phantomjs = require('phantomjs')
+catch err
+  console.log('html-pdf: Failed to load PhantomJS module.', err)
 
 #
 # phantomjs version 1.8.1 and later should work.
@@ -26,6 +30,8 @@ module.exports = class PDF
       @script = path.join(__dirname, 'scripts', 'pdf_a4_portrait.js')
 
     @options.filename = path.resolve(@options.filename) if @options.filename
+    @options.phantomPath ?= phantomjs?.path
+    assert(@options.phantomPath, "html-pdf: Failed to load PhantomJS module. You have to set the path to the PhantomJS binary using 'options.phantomPath'")
     assert(typeof @html is 'string' && @html.length, "html-pdf: Can't create a pdf without an html string")
 
 
@@ -63,7 +69,7 @@ module.exports = class PDF
 
 
   exec: (callback) ->
-    child = childprocess.spawn(phantomjs.path, [@script])
+    child = childprocess.spawn(@options.phantomPath, [@script])
     stdout = []
     stderr = []