Use alternative loading of html.

Also add some nicer error handling.

Author: marcbachmann

lib/index.coffee

@@ -3,13 +3,13 @@ spawn = require('child_process').spawn
 path = require('path')
 phantomjs = require('phantomjs')
 
-# 
+#
 # phantomjs version 1.8.1 and later should work. Ubuntu has some problems when trying to buffer to /dev/stdout
-# 
+#
 # Create a PDF file out of an html string.
-# 
+#
 # Regions for the PDF page are:
-# 
+#
 # - Page Header  -> document.getElementById('pageHeader')
 # - Page Content -> document.getElementById('pageContent')
 # - Page Footer  -> document.getElementById('pageFooter')
@@ -22,16 +22,16 @@ exports.create = (string, options, callback) ->
     callback = options
     options = {}
 
-  return callback(new Error("Can't create pdf without content")) unless string?.length
-  child = spawn(phantomjs.path, [options.script || script, string.length, JSON.stringify(options)])
+  return callback(new Error("html-pdf: Can't create a pdf without content")) unless string?.length
+  child = spawn(phantomjs.path, [options.script || script])
   stdout = []
   stderr = []
 
   timeout = setTimeout ->
     child.stdin.end()
     child.kill()
-    stderr = [new Buffer('PDF creation timeout. PDF generation script did not end.')] unless stderr.length
-  , parseInt(options.timeout) || 10000
+    stderr = [new Buffer('html-pdf: PDF generation timeout. Phantom.js script did not exit.')] unless stderr.length
+  , parseInt(options.timeout) || 30000
 
   child.stdout.on 'data', (buffer) ->
     stdout.push(buffer)
@@ -45,23 +45,28 @@ exports.create = (string, options, callback) ->
     # Clean up the timeout cause the process ended anyways
     clearTimeout(timeout)
     if (stderr.length || code) > 0
-      error = new Error(Buffer.concat(stderr).toString())
+      error = new Error(Buffer.concat(stderr).toString() || 'Unknown Error')
       return callback(error)
 
     file = Buffer.concat(stdout)
-    if isFile = /^\%PDF/.test(file.slice(0, 4).toString())
-      callback(null, file)
+    isFileBuffer = /^\%PDF/.test(file.slice(0, 4).toString())
 
-    else
+    if options.filename
+      callback(null, file.toString())
+
+    else if !isFileBuffer
       filename = file.toString()
       fs.readFile filename, (err, buffer) ->
         return callback(err) if err
-
-        # Only delete file when options.filename is not defined
-        unless options.filename
-          fs.unlink filename, (err) ->
-            callback(err, buffer)
-        else
+        fs.unlink filename, (err) ->
           callback(err, buffer)
 
-  child.stdin.write(string, 'utf8')
+    else
+      callback(null, file)
+
+
+  content =
+    html: string
+    options: options
+
+  child.stdin.write(JSON.stringify(content)+'\n', 'utf8')

lib/index.js

@@ -11,24 +11,24 @@ phantomjs = require('phantomjs');
 script = path.join(__dirname, 'scripts/pdf_a4_portrait.coffee');
 
 exports.create = function(string, options, callback) {
-  var child, stderr, stdout, timeout;
+  var child, content, stderr, stdout, timeout;
   if (arguments.length === 2) {
     callback = options;
     options = {};
   }
   if (!(string != null ? string.length : void 0)) {
-    return callback(new Error("Can't create pdf without content"));
+    return callback(new Error("html-pdf: Can't create a pdf without content"));
   }
-  child = spawn(phantomjs.path, [options.script || script, string.length, JSON.stringify(options)]);
+  child = spawn(phantomjs.path, [options.script || script]);
   stdout = [];
   stderr = [];
   timeout = setTimeout(function() {
     child.stdin.end();
     child.kill();
     if (!stderr.length) {
-      return stderr = [new Buffer('PDF creation timeout. PDF generation script did not end.')];
+      return stderr = [new Buffer('html-pdf: PDF generation timeout. Phantom.js script did not exit.')];
     }
-  }, parseInt(options.timeout) || 10000);
+  }, parseInt(options.timeout) || 30000);
   child.stdout.on('data', function(buffer) {
     return stdout.push(buffer);
   });
@@ -38,30 +38,33 @@ exports.create = function(string, options, callback) {
     return child.kill();
   });
   child.on('exit', function(code) {
-    var error, file, filename, isFile;
+    var error, file, filename, isFileBuffer;
     clearTimeout(timeout);
     if ((stderr.length || code) > 0) {
-      error = new Error(Buffer.concat(stderr).toString());
+      error = new Error(Buffer.concat(stderr).toString() || 'Unknown Error');
       return callback(error);
     }
     file = Buffer.concat(stdout);
-    if (isFile = /^\%PDF/.test(file.slice(0, 4).toString())) {
-      return callback(null, file);
-    } else {
+    isFileBuffer = /^\%PDF/.test(file.slice(0, 4).toString());
+    if (options.filename) {
+      return callback(null, file.toString());
+    } else if (!isFileBuffer) {
       filename = file.toString();
       return fs.readFile(filename, function(err, buffer) {
         if (err) {
           return callback(err);
         }
-        if (!options.filename) {
-          return fs.unlink(filename, function(err) {
-            return callback(err, buffer);
-          });
-        } else {
+        return fs.unlink(filename, function(err) {
           return callback(err, buffer);
-        }
+        });
       });
+    } else {
+      return callback(null, file);
     }
   });
-  return child.stdin.write(string, 'utf8');
+  content = {
+    html: string,
+    options: options
+  };
+  return child.stdin.write(JSON.stringify(content) + '\n', 'utf8');
 };

lib/scripts/pdf_a4_portrait.coffee

@@ -1,11 +1,26 @@
-sys = require('system')
+system = require('system')
 webpage = require('webpage')
 
+# Error handler
+exit = (error) ->
+  message = error if typeof error is 'string'
+  system.stderr.write("html-pdf: #{message || "Unknown Error #{error}"}\n") if error
+  phantom.exit(if error then 1 else 0)
+
+
+# Force cleanup after 2 minutes
+setTimeout ->
+  exit('Force timeout')
+, 120000
+
+
+# Load configurations from stdin
+json = JSON.parse(system.stdin.readLine())
+exit('Did not receive any html') if !json.html?.trim()
+
+options = json.options
 page = webpage.create()
-bufferSize = sys.args[1]
-options = {}
-options = JSON.parse(sys.args[2]) if typeof sys.args[2] is 'string'
-page.content = sys.stdin.read(bufferSize)
+page.content = json.html
 
 
 # Set up content
@@ -74,14 +89,13 @@ page.onLoadFinished = (status) ->
   # Option 1: Output file to stdout
   # Not working in Ubuntu 12.04 (at least not in my environment)
   if options.buffer
+    system.stderr.write('html-pdf: options.buffer is deprecated. Because of compatibility issues this method will no longer supported.\n')
     page.render('/dev/stdout', fileOptions)
 
-
   # Option 2: Output filename to stdout
   else
-    filename = options.filename || ("#{options.directory || '/tmp'}/html-pdf-#{sys.pid}-#{bufferSize}.#{fileOptions.type}")
+    filename = options.filename || ("#{options.directory || '/tmp'}/html-pdf-#{system.pid}.#{fileOptions.type}")
     page.render(filename, fileOptions)
-    sys.stdout.write(filename)
-
+    system.stdout.write(filename)
 
-  phantom.exit(0)
+  exit(null)