Merge pull request #3 from woylie/hidden-input-for-type

Hidden input for type

Author: woylie

lib/polymorphic_embed.ex

@@ -46,11 +46,14 @@ defmodule PolymorphicEmbed do
           }
       end)
 
+    type_field = Keyword.get(opts, :type_field, :__type__)
+
     %{
       default: Keyword.get(opts, :default, nil),
       on_replace: Keyword.fetch!(opts, :on_replace),
       on_type_not_found: Keyword.get(opts, :on_type_not_found, :changeset_error),
-      type_field: Keyword.get(opts, :type_field, :__type__) |> to_string(),
+      type_field: type_field |> to_string(),
+      type_field_atom: type_field,
       types_metadata: types_metadata
     }
   end
@@ -384,7 +387,8 @@ defmodule PolymorphicEmbed do
     Enum.find(types_metadata, &(type == to_string(&1.type)))
   end
 
-  defp get_field_options(schema, field) do
+  @doc false
+  def get_field_options(schema, field) do
     try do
       schema.__schema__(:type, field)
     rescue

lib/polymorphic_embed/html/form.ex

@@ -153,6 +153,9 @@ if Code.ensure_loaded?(Phoenix.HTML) && Code.ensure_loaded?(Phoenix.HTML.Form) d
             valid?: errors == []
         }
 
+        %schema{} = form.source.data
+        %{type_field_atom: type_field} = PolymorphicEmbed.get_field_options(schema, field)
+
         %Phoenix.HTML.Form{
           source: changeset,
           impl: Phoenix.HTML.FormData.Ecto.Changeset,
@@ -162,7 +165,7 @@ if Code.ensure_loaded?(Phoenix.HTML) && Code.ensure_loaded?(Phoenix.HTML.Form) d
           errors: errors,
           data: data,
           params: params,
-          hidden: [__type__: to_string(type)],
+          hidden: [{type_field, to_string(type)}],
           options: options
         }
       end)

test/polymorphic_embed_test.exs

@@ -1582,7 +1582,7 @@ defmodule PolymorphicEmbedTest do
   end
 
   describe "polymorphic_embed_inputs_for/2" do
-    test "generates forms that can be rendered" do
+    test "generates forms that can be rendered (custom type field/identify_by_fields)" do
       reminder_module = get_module(Reminder, :polymorphic)
 
       attrs = %{
@@ -1607,13 +1607,78 @@ defmodule PolymorphicEmbedTest do
         )
         |> Floki.parse_fragment!()
 
-      assert [input] = Floki.find(html, "#reminder_channel___type__")
+      assert [input] = Floki.find(html, "#reminder_channel_my_type_field")
+      assert Floki.attribute(input, "name") == ["reminder[channel][my_type_field]"]
       assert Floki.attribute(input, "type") == ["hidden"]
       assert Floki.attribute(input, "value") == ["email"]
 
       assert [input] = Floki.find(html, "#reminder_channel_number")
       assert Floki.attribute(input, "type") == ["text"]
     end
+
+    test "generates forms that can be rendered (custom type field)" do
+      reminder_module = get_module(Reminder, :polymorphic)
+
+      attrs = %{
+        date: ~U[2020-05-28 02:57:19Z],
+        text: "This is an Email reminder",
+        channel3: %{
+          my_type_field: "email"
+        }
+      }
+
+      changeset =
+        reminder_module
+        |> struct()
+        |> reminder_module.changeset(attrs)
+
+      html =
+        render_component(
+          &liveview_form/1,
+          %{changeset: changeset, field: :channel3}
+        )
+        |> Floki.parse_fragment!()
+
+      assert [input] = Floki.find(html, "#reminder_channel3_my_type_field")
+      assert Floki.attribute(input, "name") == ["reminder[channel3][my_type_field]"]
+      assert Floki.attribute(input, "type") == ["hidden"]
+      assert Floki.attribute(input, "value") == ["email"]
+    end
+
+    test "generates forms that can be rendered (default type field)" do
+      reminder_module = get_module(Reminder, :polymorphic)
+
+      attrs = %{
+        date: ~U[2020-05-28 02:57:19Z],
+        text: "This is an Email reminder",
+        channel2: %{
+          __type__: "email",
+          address: "a",
+          valid: true,
+          confirmed: true
+        }
+      }
+
+      changeset =
+        reminder_module
+        |> struct()
+        |> reminder_module.changeset(attrs)
+
+      html =
+        render_component(
+          &liveview_form/1,
+          %{changeset: changeset, field: :channel2}
+        )
+        |> Floki.parse_fragment!()
+
+      assert [input] = Floki.find(html, "#reminder_channel2___type__")
+      assert Floki.attribute(input, "name") == ["reminder[channel2][__type__]"]
+      assert Floki.attribute(input, "type") == ["hidden"]
+      assert Floki.attribute(input, "value") == ["email"]
+
+      assert [input] = Floki.find(html, "#reminder_channel2_number")
+      assert Floki.attribute(input, "type") == ["text"]
+    end
   end
 
   test "inputs_for/4" do
@@ -1644,7 +1709,7 @@ defmodule PolymorphicEmbedTest do
       expected_contents =
         if(polymorphic?(generator),
           do:
-            ~s(<input id="reminder_channel___type__" name="reminder[channel][__type__]" type="hidden" value="email"><input id="reminder_channel_address" name="reminder[channel][address]" type="text" value="a">),
+            ~s(<input id="reminder_channel_my_type_field" name="reminder[channel][my_type_field]" type="hidden" value="email"><input id="reminder_channel_address" name="reminder[channel][address]" type="text" value="a">),
           else:
             ~s(<input id="reminder_channel_address" name="reminder[channel][address]" type="text" value="a">)
         )
@@ -1665,7 +1730,7 @@ defmodule PolymorphicEmbedTest do
       expected_contents =
         if(polymorphic?(generator),
           do:
-            ~s(<input id="reminder_channel___type__" name="reminder[channel][__type__]" type="hidden" value="email"><input id="reminder_channel_address" name="reminder[channel][address]" type="text" value="a">),
+            ~s(<input id="reminder_channel_my_type_field" name="reminder[channel][my_type_field]" type="hidden" value="email"><input id="reminder_channel_address" name="reminder[channel][address]" type="text" value="a">),
           else:
             ~s(<input id="reminder_channel_address" name="reminder[channel][address]" type="text" value="a">)
         )
@@ -1707,7 +1772,7 @@ defmodule PolymorphicEmbedTest do
       expected_contents =
         if(polymorphic?(generator),
           do:
-            ~s(<input id="reminder_channel___type__" name="reminder[channel][__type__]" type="hidden" value="sms"><input id="reminder_channel_number" name="reminder[channel][number]" type="text" value="1">),
+            ~s(<input id="reminder_channel_my_type_field" name="reminder[channel][my_type_field]" type="hidden" value="sms"><input id="reminder_channel_number" name="reminder[channel][number]" type="text" value="1">),
           else:
             ~s(<input id="reminder_channel_number" name="reminder[channel][number]" type="text" value="1">)
         )
@@ -1728,7 +1793,7 @@ defmodule PolymorphicEmbedTest do
       expected_contents =
         if(polymorphic?(generator),
           do:
-            ~s(<input id="reminder_channel___type__" name="reminder[channel][__type__]" type="hidden" value="sms"><input id="reminder_channel_number" name="reminder[channel][number]" type="text" value="1">),
+            ~s(<input id="reminder_channel_my_type_field" name="reminder[channel][my_type_field]" type="hidden" value="sms"><input id="reminder_channel_number" name="reminder[channel][number]" type="text" value="1">),
           else:
             ~s(<input id="reminder_channel_number" name="reminder[channel][number]" type="text" value="1">)
         )