MSC4306: Thread Subscriptions Tests (matrix-org#795)

* MSC4306: Thread Subscriptions Tests

* Enable MSC4306 tests in CI for Synapse

* GetPushRule -> MustGetPushRule

* Add non-failing GetPushRule

* Disable MSC4306 push rules in non-MSC4306 test

Author: reivilibre

.github/workflows/ci.yaml

@@ -42,7 +42,7 @@ jobs:
           - homeserver: Synapse
             repo: element-hq/synapse
             tags: synapse_blacklist
-            packages: ./tests/msc3874 ./tests/msc3902
+            packages: ./tests/msc3874 ./tests/msc3902 ./tests/msc4306
             env: "COMPLEMENT_ENABLE_DIRTY_RUNS=1 COMPLEMENT_SHARE_ENV_PREFIX=PASS_ PASS_SYNAPSE_COMPLEMENT_DATABASE=sqlite"
             timeout: 20m
 

client/client.go

@@ -261,12 +261,12 @@ func (c *CSAPI) GetAllPushRules(t ct.TestLike) gjson.Result {
 	return gjson.ParseBytes(pushRulesBytes)
 }
 
-// GetPushRule queries the contents of a client's push rule by scope, kind and rule ID.
+// MustGetPushRule queries the contents of a client's push rule by scope, kind and rule ID.
 // A parsed gjson result is returned. Fails the test if the query to server returns a non-2xx status code.
 //
 // Example of checking that a global underride rule contains the expected actions:
 //
-//	containsDisplayNameRule := c.GetPushRule(t, "global", "underride", ".m.rule.contains_display_name")
+//	containsDisplayNameRule := c.MustGetPushRule(t, "global", "underride", ".m.rule.contains_display_name")
 //	must.MatchGJSON(
 //	  t,
 //	  containsDisplayNameRule,
@@ -276,14 +276,23 @@ func (c *CSAPI) GetAllPushRules(t ct.TestLike) gjson.Result {
 //	    map[string]interface{}{"set_tweak": "highlight"},
 //	  }),
 //	)
-func (c *CSAPI) GetPushRule(t ct.TestLike, scope string, kind string, ruleID string) gjson.Result {
+func (c *CSAPI) MustGetPushRule(t ct.TestLike, scope string, kind string, ruleID string) gjson.Result {
 	t.Helper()
 
-	res := c.MustDo(t, "GET", []string{"_matrix", "client", "v3", "pushrules", scope, kind, ruleID})
+	res := c.GetPushRule(t, scope, kind, ruleID)
+	mustRespond2xx(t, res)
+
 	pushRuleBytes := ParseJSON(t, res)
 	return gjson.ParseBytes(pushRuleBytes)
 }
 
+// GetPushRule queries the contents of a client's push rule by scope, kind and rule ID.
+func (c *CSAPI) GetPushRule(t ct.TestLike, scope string, kind string, ruleID string) *http.Response {
+	t.Helper()
+
+	return c.Do(t, "GET", []string{"_matrix", "client", "v3", "pushrules", scope, kind, ruleID})
+}
+
 // SetPushRule creates a new push rule on the user, or modifies an existing one.
 // If `before` or `after` parameters are not set to an empty string, their values
 // will be set as the `before` and `after` query parameters respectively on the
@@ -310,6 +319,14 @@ func (c *CSAPI) SetPushRule(t ct.TestLike, scope string, kind string, ruleID str
 	return c.MustDo(t, "PUT", []string{"_matrix", "client", "v3", "pushrules", scope, kind, ruleID}, WithJSONBody(t, body), WithQueries(queryParams))
 }
 
+// MustDisablePushRule disables a push rule on the user.
+// Fails the test if response is non-2xx.
+func (c *CSAPI) MustDisablePushRule(t ct.TestLike, scope string, kind string, ruleID string) {
+	c.MustDo(t, "PUT", []string{"_matrix", "client", "v3", "pushrules", scope, kind, ruleID, "enabled"}, WithJSONBody(t, map[string]interface{}{
+		"enabled": false,
+	}))
+}
+
 // Unsafe_SendEventUnsynced sends `e` into the room. This function is UNSAFE as it does not wait
 // for the event to be fully processed. This can cause flakey tests. Prefer `SendEventSynced`.
 // Returns the event ID of the sent event.

tests/csapi/thread_notifications_test.go

@@ -51,6 +51,21 @@ func syncHasThreadedReadReceipt(roomID, userID, eventID, threadID string) client
 	})
 }
 
+// Disables push rules that are introduced in MSC4306 (if present),
+// because they interfere with the normal semantics of notifications in threads.
+func disableMsc4306PushRules(t *testing.T, user *client.CSAPI) {
+	rules := []string{".io.element.msc4306.rule.subscribed_thread", ".io.element.msc4306.rule.unsubscribed_thread"}
+	for _, rule := range rules {
+		res := user.GetPushRule(t, "global", "postcontent", rule)
+		if res.StatusCode == 404 {
+			// No push rule to disable
+			continue
+		}
+
+		user.MustDisablePushRule(t, "global", "postcontent", rule)
+	}
+}
+
 // Test behavior of threaded receipts and notifications.
 //
 // 1. Send a series of messages, some of which are in threads.
@@ -79,7 +94,9 @@ func TestThreadedReceipts(t *testing.T) {
 
 	// Create a room with alice and bob.
 	alice := deployment.Register(t, "hs1", helpers.RegistrationOpts{})
+	disableMsc4306PushRules(t, alice)
 	bob := deployment.Register(t, "hs1", helpers.RegistrationOpts{})
+	disableMsc4306PushRules(t, bob)
 
 	roomID := alice.MustCreateRoom(t, map[string]interface{}{"preset": "public_chat"})
 	bob.MustJoinRoom(t, roomID, nil)
@@ -312,7 +329,9 @@ func TestThreadReceiptsInSyncMSC4102(t *testing.T) {
 
 	// Create a room with alice and bob.
 	alice := deployment.Register(t, "hs1", helpers.RegistrationOpts{})
+	disableMsc4306PushRules(t, alice)
 	bob := deployment.Register(t, "hs2", helpers.RegistrationOpts{})
+	disableMsc4306PushRules(t, bob)
 	roomID := alice.MustCreateRoom(t, map[string]interface{}{"preset": "public_chat"})
 	bob.MustJoinRoom(t, roomID, []spec.ServerName{
 		deployment.GetFullyQualifiedHomeserverName(t, "hs1"),

tests/msc3930/msc3930_test.go

@@ -39,7 +39,7 @@ func TestPollsLocalPushRules(t *testing.T) {
 		// Request each of the push rule IDs defined by MSC3930 and verify their structure.
 
 		// This push rule silences all poll responses.
-		pollResponseRule := alice.GetPushRule(t, "global", "override", pollResponseRuleID)
+		pollResponseRule := alice.MustGetPushRule(t, "global", "override", pollResponseRuleID)
 		must.MatchGJSON(
 			t,
 			pollResponseRule,
@@ -55,7 +55,7 @@ func TestPollsLocalPushRules(t *testing.T) {
 		)
 
 		// This push rule creates a sound and notifies the user when a poll is started in a one-to-one room.
-		pollStartOneToOneRule := alice.GetPushRule(t, "global", "underride", pollStartOneToOneRuleID)
+		pollStartOneToOneRule := alice.MustGetPushRule(t, "global", "underride", pollStartOneToOneRuleID)
 		must.MatchGJSON(
 			t,
 			pollStartOneToOneRule,
@@ -78,7 +78,7 @@ func TestPollsLocalPushRules(t *testing.T) {
 		)
 
 		// This push rule creates a sound and notifies the user when a poll is ended in a one-to-one room.
-		pollEndOneToOneRule := alice.GetPushRule(t, "global", "underride", pollEndOneToOneRuleID)
+		pollEndOneToOneRule := alice.MustGetPushRule(t, "global", "underride", pollEndOneToOneRuleID)
 		must.MatchGJSON(
 			t,
 			pollEndOneToOneRule,
@@ -101,7 +101,7 @@ func TestPollsLocalPushRules(t *testing.T) {
 		)
 
 		// This push rule notifies the user when a poll is started in any room.
-		pollStartRule := alice.GetPushRule(t, "global", "underride", pollStartRuleID)
+		pollStartRule := alice.MustGetPushRule(t, "global", "underride", pollStartRuleID)
 		must.MatchGJSON(
 			t,
 			pollStartRule,
@@ -118,7 +118,7 @@ func TestPollsLocalPushRules(t *testing.T) {
 		)
 
 		// This push rule notifies the user when a poll is ended in any room.
-		pollEndRule := alice.GetPushRule(t, "global", "underride", pollEndRuleID)
+		pollEndRule := alice.MustGetPushRule(t, "global", "underride", pollEndRuleID)
 		must.MatchGJSON(
 			t,
 			pollEndRule,

tests/msc4306/main_test.go

@@ -0,0 +1,11 @@
+package tests
+
+import (
+	"testing"
+
+	"github.com/matrix-org/complement"
+)
+
+func TestMain(m *testing.M) {
+	complement.TestMain(m, "msc4306")
+}