Skip to content

Commit 784b6a6

Browse files
committed
Make Travis run all mf2 tests
We mark a single test as incomplete (ie. unimplemented) because the parser implements a proposed extension to the mf2 specification while the test suite has tests that exactly match the specification.
1 parent 727a299 commit 784b6a6

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

phpunit.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
<groups>
99
<exclude>
1010
<group>microformats/tests/mf1</group>
11-
<group>microformats/tests/mf2</group>
1211
</exclude>
1312
</groups>
1413
</phpunit>

tests/Mf2/MicroformatsTestSuiteTest.php

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,12 @@ public function testMf1FromTestSuite($input, $expectedOutput)
6868
* @dataProvider mf2TestsProvider
6969
* @group microformats/tests/mf2
7070
*/
71-
public function testMf2FromTestSuite($input, $expectedOutput)
71+
public function testMf2FromTestSuite($input, $expectedOutput, $test)
7272
{
73+
if ($test === 'h-event/time') {
74+
$this->markTestIncomplete('This test does not match because we implement a proposed spec: https://github.com/microformats/microformats2-parsing/issues/4#issuecomment-373457720.');
75+
}
76+
7377
$parser = new TestSuiteParser($input, 'http://example.com/');
7478
$this->assertEquals(
7579
$this->makeComparible(json_decode($expectedOutput, true)),
@@ -135,7 +139,8 @@ public function htmlAndJsonProvider($subFolder = '')
135139
if (is_file($dir . '/' . $result)) {
136140
$tests[$testname] = array(
137141
'input' => file_get_contents($dir . '/' . $test),
138-
'expectedOutput' => file_get_contents($dir . '/' . $result)
142+
'expectedOutput' => file_get_contents($dir . '/' . $result),
143+
'name' => $testname
139144
);
140145
}
141146
}

0 commit comments

Comments
 (0)