Skip to content

Commit 54c5638

Browse files
Potential fix for pull request finding 'CodeQL / Log entries created from user input'
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
1 parent 8fd9d35 commit 54c5638

1 file changed

Lines changed: 6 additions & 5 deletions

File tree

App/backend-api/Microsoft.GS.DPS.Host/API/KernelMemory/KernelMemory.cs

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -295,24 +295,25 @@ ILogger<KernelMemory> logger
295295
var requestId = httpContext.TraceIdentifier;
296296
telemetryHelper.SetActivityTag("requestId", requestId);
297297
var startTime = DateTimeOffset.UtcNow;
298+
var safeDocumentId = (documentId ?? "null").Replace("\r", string.Empty).Replace("\n", string.Empty);
298299

299300
// Trace: Delete request received
300301
logger.LogInformation("[{RequestId}] Document delete request received. Endpoint: /Documents/{documentId}, DocumentId: {DocumentId}",
301-
requestId, documentId ?? "null");
302+
requestId, safeDocumentId);
302303

303304
// Track delete started
304305
telemetryHelper.TrackEvent("DocumentDeleteStarted", new Dictionary<string, string>
305306
{
306307
{ "requestId", requestId },
307308
{ "endpoint", "/Documents/{documentId}" },
308-
{ "documentId", documentId }
309+
{ "documentId", safeDocumentId }
309310
});
310311

311312
try
312313
{
313314
// Trace: Beginning delete operation
314315
logger.LogDebug("[{RequestId}] Calling kernel memory to delete document: {DocumentId}",
315-
requestId, documentId);
316+
requestId, safeDocumentId);
316317

317318
await kernelMemory.DeleteDocument(documentId);
318319
var duration = (DateTimeOffset.UtcNow - startTime).TotalSeconds;
@@ -321,13 +322,13 @@ ILogger<KernelMemory> logger
321322
logger.LogInformation("[{RequestId}] Document deleted successfully. Duration: {Duration}s, DocumentId: {DocumentId}",
322323
requestId,
323324
duration.ToString("F2"),
324-
documentId);
325+
safeDocumentId);
325326

326327
telemetryHelper.TrackEvent("DocumentDeleteSuccess", new Dictionary<string, string>
327328
{
328329
{ "requestId", requestId },
329330
{ "endpoint", "/Documents/{documentId}" },
330-
{ "documentId", documentId },
331+
{ "documentId", safeDocumentId },
331332
{ "duration", duration.ToString("F2") }
332333
}, new Dictionary<string, double>
333334
{

0 commit comments

Comments
 (0)