fix for app insight

Author: Kanchan-Microsoft

App/backend-api/Microsoft.GS.DPS.Host/Helpers/TelemetryHelper.cs

@@ -17,12 +17,20 @@ public TelemetryHelper(TelemetryClient? telemetryClient, ILogger<TelemetryHelper
         {
             _telemetryClient = telemetryClient;
             _logger = logger;
-            _isConfigured = !string.IsNullOrEmpty(_telemetryClient?.InstrumentationKey);
+            
+            // Check if Application Insights is properly configured
+            // TelemetryConfiguration.ConnectionString is the modern way (replaces deprecated InstrumentationKey)
+            _isConfigured = _telemetryClient != null && 
+                           !string.IsNullOrEmpty(_telemetryClient.TelemetryConfiguration?.ConnectionString);
 
             if (!_isConfigured)
             {
                 _logger.LogWarning("Application Insights is not configured. Telemetry tracking will be disabled.");
             }
+            else
+            {
+                _logger.LogInformation("Application Insights is configured successfully. Telemetry tracking is enabled.");
+            }
         }
 
         /// <summary>

App/backend-api/Microsoft.GS.DPS.Host/Program.cs

@@ -18,25 +18,26 @@
 //Load Inject Settings and Load AppConfiguration Objects
 AppConfiguration.Config(builder);
 
-// Configure Application Insights
+// Configure Application Insights - Always register to ensure TelemetryClient is available for DI
 var connectionString = builder.Configuration["ApplicationInsights:ConnectionString"];
-if (!string.IsNullOrEmpty(connectionString))
+builder.Services.AddApplicationInsightsTelemetry(options =>
 {
-    builder.Services.AddApplicationInsightsTelemetry(options =>
+    if (!string.IsNullOrEmpty(connectionString))
     {
         options.ConnectionString = connectionString;
         options.EnableAdaptiveSampling = builder.Configuration.GetValue<bool>("ApplicationInsights:EnableAdaptiveSampling", true);
         options.EnablePerformanceCounterCollectionModule = builder.Configuration.GetValue<bool>("ApplicationInsights:EnablePerformanceCounterCollectionModule", true);
         options.EnableQuickPulseMetricStream = builder.Configuration.GetValue<bool>("ApplicationInsights:EnableQuickPulseMetricStream", true);
-    });
+    }
+});
 
-    builder.Logging.AddApplicationInsights();
-}
-else
+// Configure logging
+if (!string.IsNullOrEmpty(connectionString))
 {
-    builder.Logging.AddConsole();
-    builder.Logging.AddDebug();
+    builder.Logging.AddApplicationInsights();
 }
+builder.Logging.AddConsole();
+builder.Logging.AddDebug();
 
 //Bson Register Class Maps
 //MongoDbConfig.RegisterClassMaps();

infra/main.bicep

@@ -531,6 +531,10 @@ module avmAppConfig 'br/public:avm/res/app-configuration/configuration-store:0.6
     ]
 
     keyValues: [
+      {
+        name: 'ApplicationInsights:ConnectionString'
+        value: enableMonitoring ? applicationInsights!.outputs.connectionString : ''
+      }
       {
         name: 'Application:AIServices:GPT-4o-mini:Endpoint'
         value: avmOpenAi.outputs.endpoint
@@ -1115,10 +1119,10 @@ output AZ_GPT_EMBEDDING_MODEL_NAME string = embeddingModelDeployment.modelName
 output AZ_GPT_EMBEDDING_MODEL_ID string = embeddingModelDeployment.deploymentName
 
 @description('Contains Application Insights Connection String.')
-output APPLICATIONINSIGHTS_CONNECTION_STRING string = enableMonitoring ? applicationInsights.outputs.connectionString : ''
+output APPLICATIONINSIGHTS_CONNECTION_STRING string = enableMonitoring ? applicationInsights!.outputs.connectionString : ''
 
 @description('Contains Application Insights Instrumentation Key.')
-output APPLICATIONINSIGHTS_INSTRUMENTATION_KEY string = enableMonitoring ? applicationInsights.outputs.instrumentationKey : ''
+output APPLICATIONINSIGHTS_INSTRUMENTATION_KEY string = enableMonitoring ? applicationInsights!.outputs.instrumentationKey : ''
 
 @description('Contains Application Insights Name.')
-output APPLICATIONINSIGHTS_NAME string = enableMonitoring ? applicationInsights.outputs.name : ''
+output APPLICATIONINSIGHTS_NAME string = enableMonitoring ? applicationInsights!.outputs.name : ''