Merge down from hotfix

Author: Shreyas-Microsoft

.flake8

@@ -2,4 +2,4 @@
 max-line-length = 88
 extend-ignore = E501
 exclude = .venv, frontend
-ignore = E203, W503, G004, G200,B008,ANN,D100,D101,D102,D103,D104,D105,D106,D107
+ignore = E203, W503, G004, G200,B008,ANN,D100,D101,D102,D103,D104,D105,D106,D107,D205,D400,D401,D200

src/backend/api/api_routes.py

@@ -4,6 +4,12 @@
 import io
 import zipfile
 
+from api.auth.auth_utils import get_authenticated_user
+from api.status_updates import app_connection_manager, close_connection
+
+from common.logger.app_logger import AppLogger
+from common.services.batch_service import BatchService
+
 from fastapi import (
     APIRouter,
     File,
@@ -16,17 +22,11 @@
 )
 from fastapi.responses import Response
 
-from api.auth.auth_utils import get_authenticated_user
-from api.status_updates import app_connection_manager, close_connection
-from common.logger.app_logger import AppLogger
-from common.services.batch_service import BatchService
 from sql_agents.process_batch import process_batch_async
 
 router = APIRouter()
 logger = AppLogger("APIRoutes")
 
-# start processing the batch
-# from sql_agents_start import process_batch_async  # noqa: E402
 
 # start processing the batch
 @router.post("/start-processing")

src/backend/common/config/config.py

@@ -17,7 +17,6 @@
 from azure.identity.aio import ClientSecretCredential, DefaultAzureCredential
 
 
-
 class Config:
     """Configuration class for the application."""
 

src/backend/common/database/database_base.py

@@ -4,11 +4,10 @@
 from abc import ABC, abstractmethod
 from typing import Dict, List, Optional
 
-from common.models.api import AgentType, BatchRecord, FileRecord, LogType
+from common.models.api import BatchRecord, FileRecord, LogType
 
 from semantic_kernel.contents import AuthorRole
 
-from common.models.api import BatchRecord, FileRecord, LogType
 from sql_agents.helpers.models import AgentType
 
 

src/backend/sql_agents/agents/agent_base.py

@@ -8,6 +8,7 @@
     ResponseFormatJsonSchema,
     ResponseFormatJsonSchemaType,
 )
+
 from semantic_kernel.agents.azure_ai.azure_ai_agent import AzureAIAgent
 from semantic_kernel.functions import KernelArguments
 

src/backend/sql_agents/convert_script.py

@@ -7,9 +7,8 @@
 import json
 import logging
 
-from semantic_kernel.contents import AuthorRole, ChatMessageContent
-
 from api.status_updates import send_status_update
+
 from common.models.api import (
     FileProcessUpdate,
     FileRecord,
@@ -18,6 +17,9 @@
     ProcessStatus,
 )
 from common.services.batch_service import BatchService
+
+from semantic_kernel.contents import AuthorRole, ChatMessageContent
+
 from sql_agents.agents.fixer.response import FixerResponse
 from sql_agents.agents.migrator.response import MigratorResponse
 from sql_agents.agents.picker.response import PickerResponse

src/backend/sql_agents/helpers/agents_manager.py

@@ -33,7 +33,8 @@ def __init__(self):
     @classmethod
     async def create(cls, config: AgentBaseConfig):
         """Create the SQL agents for migration.
-        Required as init cannot be async"""
+        Required as init cannot be async
+        """
         self = cls()  # Create an instance
         try:
             self.agent_config = config
@@ -71,7 +72,7 @@ def idx_agents(self):
         }
 
     async def delete_agents(self):
-        """cleans up the agents from Azure Foundry"""
+        """Cleans up the agents from Azure Foundry"""
         try:
             for agent in self.agents:
                 await self.agent_config.ai_project_client.agents.delete_agent(agent.id)

src/backend/sql_agents/helpers/comms_manager.py

@@ -20,8 +20,7 @@ class SelectionStrategy(SequentialSelectionStrategy):
 
         # Select the next agent that should take the next turn in the chat
         async def select_agent(self, agents, history):
-            """ "Check which agent should take the next turn in the chat."""
-
+            """Check which agent should take the next turn in the chat."""
             match history[-1].name:
                 case AgentType.MIGRATOR.value:
                     # The Migrator should go first

src/backend/sql_agents/process_batch.py

@@ -6,13 +6,10 @@
 
 import logging
 
+from api.status_updates import send_status_update
+
 from azure.identity.aio import DefaultAzureCredential
-from fastapi import HTTPException
-from semantic_kernel.agents import AzureAIAgent  # pylint: disable=E0611
-from semantic_kernel.contents import AuthorRole
-from semantic_kernel.exceptions.service_exceptions import ServiceResponseException
 
-from api.status_updates import send_status_update
 from common.models.api import (
     FileProcessUpdate,
     FileRecord,
@@ -22,6 +19,15 @@
 )
 from common.services.batch_service import BatchService
 from common.storage.blob_factory import BlobStorageFactory
+
+from fastapi import HTTPException
+
+
+from semantic_kernel.agents import AzureAIAgent  # pylint: disable=E0611
+from semantic_kernel.contents import AuthorRole
+from semantic_kernel.exceptions.service_exceptions import ServiceResponseException
+
+
 from sql_agents.agents.agent_config import AgentBaseConfig
 from sql_agents.convert_script import convert_script
 from sql_agents.helpers.agents_manager import SqlAgents
@@ -36,7 +42,7 @@
 async def process_batch_async(
     batch_id: str, convert_from: str = "informix", convert_to: str = "tsql"
 ):
-    """central batch processing function to process each file in the batch"""
+    """Central batch processing function to process each file in the batch"""
     logger.info("Processing batch: %s", batch_id)
     storage = await BlobStorageFactory.get_storage()
     batch_service = BatchService()
@@ -154,7 +160,7 @@ async def process_batch_async(
 async def process_error(
     ex: Exception, file_record: FileRecord, batch_service: BatchService
 ):
-    """insert data base write to file record stating invalid file and send ws notification"""
+    """Insert data base write to file record stating invalid file and send ws notification"""
     await batch_service.create_file_log(
         file_id=str(file_record.file_id),
         description=f"Error processing file {ex}",