Skip to content

Commit 6589e79

Browse files
Merge branch 'main' into hotfix
2 parents 28f55d5 + ba65c5f commit 6589e79

16 files changed

Lines changed: 390 additions & 228 deletions

README.md

Lines changed: 14 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -75,28 +75,24 @@ This diagram double-clicks into the agentic framework for the code conversion pr
7575
QUICK DEPLOY
7676
</h2>
7777

78-
79-
| [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/microsoft/Modernize-your-Code-Solution-Accelerator) | [![Open in Dev Containers](https://img.shields.io/static/v1?style=for-the-badge&label=Dev%20Containers&message=Open&color=blue&logo=visualstudiocode)](https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/microsoft/Modernize-your-Code-Solution-Accelerator) | [![Deploy to Azure](https://aka.ms/deploytoazurebutton)](https://portal.azure.com/#create/Microsoft.Template/uri/https%3A%2F%2Fraw.githubusercontent.com%2Fmicrosoft%2FModernize-your-code-solution-accelerator%2Frefs%2Fheads%2Fmain%2Finfra%2Fmain.json) |
80-
|---|---|---|
81-
8278
### **Prerequisites**
8379

8480
To deploy this solution accelerator, ensure you have access to an [Azure subscription](https://azure.microsoft.com/free/) with the necessary permissions to create **resource groups and resources**. Follow the steps in [Azure Account Set Up](./docs/AzureAccountSetUp.md)
8581

8682
Check the [Azure Products by Region](https://azure.microsoft.com/en-us/explore/global-infrastructure/products-by-region/?products=all&regions=all) page and select a **region** where the following services are available:
8783

8884
- Azure AI Foundry
89-
- Azure OpenAI Service
90-
- Embedding Deployment Capacity
85+
- Azure OpenAI Service
9186
- GPT Model Capacity
9287

9388
Here are some example regions where the services are available: East US, East US2, Japan East, UK South, Sweden Central.
9489

95-
This accelerator can be deployed with or without authentication.
90+
### ⚠️ Important: Check Azure OpenAI Quota Availability
9691

97-
* To install with authentication requires that the installer have the rights to create and register an application identity in their Azure environment.
98-
After installation is complete, follow the directions in the [App Authentication](./docs/AddAuthentication.md) document to enable authentication.
99-
* Note: If you install with authentication, all processing history and current processing will be performed for your specific user. If you deploy without authentication, all batch history from the tool will be visible to all users.
92+
➡️ To ensure sufficient quota is available in your subscription, please follow **[Quota check instructions guide](./docs/quota_check.md)** before you deploy the solution.
93+
94+
| [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/microsoft/Modernize-your-Code-Solution-Accelerator) | [![Open in Dev Containers](https://img.shields.io/static/v1?style=for-the-badge&label=Dev%20Containers&message=Open&color=blue&logo=visualstudiocode)](https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/microsoft/Modernize-your-Code-Solution-Accelerator) |
95+
|---|---|
10096

10197
### **Configurable Deployment Settings**
10298

@@ -109,13 +105,17 @@ When you start the deployment, most parameters will have **default values**, but
109105
| **AI Location** | Location for all AI services resources. This location can be different from the resource group location | None |
110106
| **Capacity** | Configure capacity for **gpt-4o**. | 5k |
111107

108+
This accelerator can be configured to use authentication.
109+
110+
* To use authentication the installer must have the rights to create and register an application identity in their Azure environment.
111+
After installation is complete, follow the directions in the [App Authentication](./docs/AddAuthentication.md) document to enable authentication.
112+
* Note: If you enable authentication, all processing history and current processing will be performed for your specific user. Without authentication, all batch history from the tool will be visible to all users.
113+
112114
### [Optional] Quota Recommendations
113115
By default, the **GPT model capacity** in deployment is set to **5k tokens**.
114116
> **We recommend increasing the capacity to 200k tokens for optimal performance.**
115117
116-
To adjust quota settings, follow these [steps](./docs/AzureGPTQuotaSettings.md)
117-
118-
**⚠️ Warning:** **Insufficient quota can cause application errors.** Please ensure you have the recommended capacity or request for additional capacity before deploying this solution.
118+
To adjust quota settings, follow these [steps](./docs/AzureGPTQuotaSettings.md)
119119

120120
### Deployment Options
121121
Pick from the options below to see step-by-step instructions for: GitHub Codespaces, VS Code Dev Containers, Local Environments, and Bicep deployments.
@@ -178,16 +178,6 @@ If you're not using one of the above options for opening the project, then you'l
178178

179179
4. Continue with the [deploying steps](#deploying).
180180

181-
</details>
182-
<details>
183-
<summary><b>Deploy with Bicep/ARM template</b></summary>
184-
185-
### Bicep
186-
187-
Click the following deployment button to create the required resources for this accelerator directly in your Azure Subscription.
188-
189-
[![Deploy to Azure](https://aka.ms/deploytoazurebutton)](https://portal.azure.com/#create/Microsoft.Template/uri/https%3A%2F%2Fraw.githubusercontent.com%2Fmarktayl1%2Ftestdeploy%2Frefs%2Fheads%2Fmain%2FCodeGenDeploy.json)
190-
191181
</details>
192182

193183
### Deploying
@@ -246,8 +236,7 @@ Responsible AI Transparency FAQ
246236
247237
Please refer to [Transparency FAQ](./TRANSPARENCY_FAQ.md) for responsible AI transparency details of this solution accelerator.
248238
249-
<h2><img src="./docs/images/read_me/supportingDocuments.png" width="64" style="max-width: 100%;">
250-
</br>
239+
<h2>
251240
Supporting Documentation
252241
</h2>
253242

docs/AzureAccountSetUp.md

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
## Azure account setup
2+
3+
1. Sign up for a [free Azure account](https://azure.microsoft.com/free/) and create an Azure Subscription.
4+
2. Check that you have the necessary permissions:
5+
* Your Azure account must have `Microsoft.Authorization/roleAssignments/write` permissions, such as [Role Based Access Control Administrator](https://learn.microsoft.com/azure/role-based-access-control/built-in-roles#role-based-access-control-administrator-preview), [User Access Administrator](https://learn.microsoft.com/azure/role-based-access-control/built-in-roles#user-access-administrator), or [Owner](https://learn.microsoft.com/azure/role-based-access-control/built-in-roles#owner).
6+
* Your Azure account also needs `Microsoft.Resources/deployments/write` permissions on the subscription level.
7+
8+
You can view the permissions for your account and subscription by following the steps below:
9+
- Navigate to the [Azure Portal](https://portal.azure.com/) and click on `Subscriptions` under 'Navigation'
10+
- Select the subscription you are using for this accelerator from the list.
11+
- If you try to search for your subscription and it does not come up, make sure no filters are selected.
12+
- Select `Access control (IAM)` and you can see the roles that are assigned to your account for this subscription.
13+
- If you want to see more information about the roles, you can go to the `Role assignments`
14+
tab and search by your account name and then click the role you want to view more information about.
-70.8 KB
Loading
-75.8 KB
Loading

docs/quota_check.md

Lines changed: 25 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,17 @@
11
## Check Quota Availability Before Deployment
22

3-
Before deploying the accelerator, **ensure sufficient quota availability** for the required model. \
3+
Before deploying the accelerator, **ensure sufficient quota availability** for the required model.
4+
> **For Global Standard | GPT-4o - the capacity to at least 200K tokens for optimal performance.**
5+
6+
### Login if you have not done so already
7+
```
8+
azd auth login
9+
```
10+
411

512
### 📌 Default Models & Capacities:
613
```
7-
gpt-4o:30, gpt-4:30
14+
gpt-4o:5
815
```
916
### 📌 Default Regions:
1017
```
@@ -15,27 +22,34 @@ eastus, uksouth, eastus2, northcentralus, swedencentral, westus, westus2, southc
1522
- Only model(s) provided → The script will check for those models in the default regions.
1623
- Only region(s) provided → The script will check default models in the specified regions.
1724
- Both models and regions provided → The script will check those models in the specified regions.
25+
- `--verbose` passed → Enables detailed logging output for debugging and traceability.
1826

1927
### **Input Formats**
20-
✔️ Run without parameters to check default models & regions:
28+
> Use the --models, --regions, and --verbose options for parameter handling:
29+
30+
✔️ Run without parameters to check default models & regions without verbose logging:
2131
```
2232
./quota_check_params.sh
2333
```
24-
✔️ Model name and required capacity in the format:
34+
✔️ Enable verbose logging:
35+
```
36+
./quota_check_params.sh --verbose
37+
```
38+
✔️ Check specific model(s) in default regions:
2539
```
26-
./quota_check_params.sh gpt-4o:30
40+
./quota_check_params.sh --models gpt-4o:30
2741
```
28-
✔️ Multiple models can be passed, separated by commas:
42+
✔️ Check default models in specific region(s):
2943
```
30-
./quota_check_params.sh gpt-4o:30,gpt-4:80
44+
./quota_check_params.sh --regions eastus,westus
3145
```
3246
✔️ Passing Both models and regions:
3347
```
34-
./quota_check_params.sh gpt-4o:30 eastus,westus2
48+
./quota_check_params.sh --models gpt-4o:30 --regions eastus,westus2
3549
```
36-
✔️ Check default models in specific regions:
50+
✔️ All parameters combined:
3751
```
38-
./quota_check_params.sh "" eastus,westus2
52+
./quota_check_params.sh --models gpt-4:30 --regions eastus,westus --verbose
3953
```
4054

4155
### **Sample Output**
@@ -83,4 +97,4 @@ The final table lists regions with available quota. You can select any of these
8397
curl -sL https://aka.ms/InstallAzureCLIDeb | sudo bash
8498
az login
8599
```
86-
6. Rerun the script after installing Azure CLI.
100+
6. Rerun the script after installing Azure CLI.

infra/deploy_ai_foundry.bicep

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,18 +9,18 @@ param aiServicesEndpoint string
99
param aiServicesKey string
1010
param aiServicesId string
1111

12-
var storageName = '${solutionName}hubstorage'
12+
var storageName = '${solutionName}hubst'
1313
var storageSkuName = 'Standard_LRS'
14-
var aiServicesName = '${solutionName}-aiservices'
15-
var workspaceName = '${solutionName}-workspace'
14+
var aiServicesName = '${solutionName}-ais'
15+
var workspaceName = '${solutionName}-log'
1616
var keyvaultName = '${solutionName}-kv'
1717
var location = solutionLocation
18-
var aiHubName = '${solutionName}-aihub'
19-
var aiHubFriendlyName = aiHubName
18+
var azureAiHubName = '${solutionName}-hub'
19+
var aiHubFriendlyName = azureAiHubName
2020
var aiHubDescription = 'AI Hub for KM template'
21-
var aiProjectName = '${solutionName}-aiproject'
21+
var aiProjectName = '${solutionName}-prj'
2222
var aiProjectFriendlyName = aiProjectName
23-
var aiSearchName = '${solutionName}-search'
23+
var aiSearchName = '${solutionName}-srch'
2424

2525

2626
resource keyVault 'Microsoft.KeyVault/vaults@2022-07-01' existing = {
@@ -112,7 +112,7 @@ resource storageroleAssignment 'Microsoft.Authorization/roleAssignments@2022-04-
112112
}
113113

114114
resource aiHub 'Microsoft.MachineLearningServices/workspaces@2023-08-01-preview' = {
115-
name: aiHubName
115+
name: azureAiHubName
116116
location: location
117117
identity: {
118118
type: 'SystemAssigned'
@@ -129,7 +129,7 @@ resource aiHub 'Microsoft.MachineLearningServices/workspaces@2023-08-01-preview'
129129
kind: 'hub'
130130

131131
resource aiServicesConnection 'connections@2024-07-01-preview' = {
132-
name: '${aiHubName}-connection-AzureOpenAI'
132+
name: '${azureAiHubName}-connection-AzureOpenAI'
133133
properties: {
134134
category: 'AIServices'
135135
target: aiServicesEndpoint
@@ -298,3 +298,5 @@ output storageAccountName string = storageNameCleaned
298298

299299
output logAnalyticsId string = logAnalytics.id
300300
output storageAccountId string = storage.id
301+
302+
output projectConnectionString string = '${split(aiHubProject.properties.discoveryUrl, '/')[2]};${subscription().subscriptionId};${resourceGroup().name};${aiHubProject.name}'

infra/deploy_managed_identity.bicep

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ param solutionName string
1010
param solutionLocation string
1111

1212
@description('Name')
13-
param miName string = '${ solutionName }-managed-identity'
13+
param miName string = '${ solutionName }-id'
1414

1515
resource managedIdentity 'Microsoft.ManagedIdentity/userAssignedIdentities@2023-01-31' = {
1616
name: miName

0 commit comments

Comments
 (0)