Skip to content

Commit 9ee00bd

Browse files
refactor: improve model deployment validation logic and messaging
1 parent 262fb56 commit 9ee00bd

1 file changed

Lines changed: 8 additions & 7 deletions

File tree

scripts/validate_model_deployment_quota.sh

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -61,20 +61,20 @@ if [[ -n "$existing" ]]; then
6161

6262
required_models=$(jq -r ".parameters.$MODELS_PARAMETER.value[].name" ./infra/main.parameters.json)
6363

64-
all_present=true
64+
missing_models=()
6565
for model in $required_models; do
6666
if ! grep -q -w "$model" <<< "$existing_deployments"; then
67-
all_present=false
68-
break
67+
missing_models+=("$model")
6968
fi
7069
done
7170

72-
if [[ "$all_present" == "true" ]]; then
73-
echo "✅ All required model deployments already exist in AI Foundry '$AIFOUNDRY_NAME'."
71+
if [[ ${#missing_models[@]} -eq 0 ]]; then
72+
echo "ℹ️ AI Foundry '$AIFOUNDRY_NAME' exists and all required model deployments are already provisioned."
7473
echo "⏭️ Skipping quota validation."
7574
exit 0
7675
else
77-
echo "🔍 Some model deployments are missing — proceeding with quota validation."
76+
echo "🔍 AI Foundry exists, but the following model deployments are missing: ${missing_models[*]}"
77+
echo "➡️ Proceeding with quota validation for missing models..."
7878
fi
7979
fi
8080

@@ -90,6 +90,7 @@ while IFS= read -r deployment; do
9090
type=${AZURE_ENV_MODEL_DEPLOYMENT_TYPE:-$(echo "$deployment" | jq -r '.sku.name')}
9191
capacity=${AZURE_ENV_MODEL_CAPACITY:-$(echo "$deployment" | jq -r '.sku.capacity')}
9292

93+
echo ""
9394
echo "🔍 Validating model deployment: $name ..."
9495
./scripts/validate_model_quota.sh --location "$LOCATION" --model "$model" --capacity "$capacity" --deployment-type "$type"
9596
exit_code=$?
@@ -104,7 +105,7 @@ while IFS= read -r deployment; do
104105
done <<< "$(echo "$aiModelDeployments")"
105106

106107
if [[ "$quotaAvailable" = false ]]; then
107-
echo "❌ ERROR: One or more model deployments failed validation."
108+
echo "❌ ERROR: One or more model deployments failed quota validation."
108109
exit 1
109110
else
110111
echo "✅ All model deployments passed quota validation successfully."

0 commit comments

Comments
 (0)