Merge pull request #411 from microsoft/feature/fix-code-quality-alerts

fix: Code Quality Fix

Author: Roopan-Microsoft

scripts/validate_bicep_params.py

@@ -110,6 +110,8 @@ def parse_parameters_env_vars(json_path: Path) -> dict[str, list[str]]:
         data = json.loads(sanitized)
         params = data.get("parameters", {})
     except json.JSONDecodeError:
+        # If JSON parsing fails, params remains empty and no variables will be found.
+        # This is acceptable as the function will return an empty result dict.
         pass
 
     # Walk each top-level parameter and scan its entire serialized value

src/backend/common/database/cosmosdb.py

@@ -110,6 +110,9 @@ async def create_batch(self, user_id: str, batch_id: UUID) -> BatchRecord:
                     self.logger.info("Returning existing batch record", batch_id=str(batch_id))
                     return BatchRecord.fromdb(batchexists)
 
+                # This line should never be reached as all paths above either return or raise
+                raise RuntimeError(f"Unexpected state while processing batch {batch_id}")
+
         except Exception as e:
             self.logger.error("Failed to create batch", error=str(e))
             raise

src/backend/sql_agents/convert_script.py

@@ -271,7 +271,6 @@ async def convert_script(
                         FileResult.ERROR,
                     ),
                 )
-                is_complete = True
                 break
 
             if comms_manager.group_chat.is_complete:

src/frontend/src/pages/modernizationPage.tsx

@@ -4,7 +4,6 @@ import Header from "../components/Header/Header";
 import HeaderTools from "../components/Header/HeaderTools";
 import PanelLeft from "../components/Panels/PanelLeft";
 import webSocketService from "../api/WebSocketService";
-import { useSelector } from 'react-redux';
 import {
   Button,
   Text,
@@ -479,9 +478,6 @@ const getPrintFileStatus = (status: string): string => {
 const ModernizationPage = () => {
   const { batchId } = useParams<{ batchId: string }>();
   const navigate = useNavigate();
-
-  // Redux state to listen for start processing completion
-  const batchState = useSelector((state: any) => state.batch);
 
   const [batchSummary, setBatchSummary] = useState<BatchSummary | null>(null);
   const styles = useStyles();
@@ -498,7 +494,6 @@ const ModernizationPage = () => {
   const [fileId, setFileId] = React.useState<string>("");
   const [expandedSections, setExpandedSections] = React.useState<string[]>([]);
   const [allFilesCompleted, setAllFilesCompleted] = useState(false);
-  const [progressPercentage, setProgressPercentage] = useState(0);
   const [isZipButtonDisabled, setIsZipButtonDisabled] = useState(true);
   const [fileLoading, setFileLoading] = useState(false);
   const [lastActivityTime, setLastActivityTime] = useState<number>(Date.now());
@@ -516,7 +511,7 @@ const ModernizationPage = () => {
         const selectedFile = files.find((f) => f.id === selectedFileId);
         if (!selectedFile || !selectedFile.translatedCode) {
           setFileLoading(true);
-          const newFileUpdate = await fetchFileFromAPI(selectedFile?.fileId || "");
+          await fetchFileFromAPI(selectedFile?.fileId || "");
           setFileLoading(false);
         } else {
 
@@ -988,13 +983,13 @@ useEffect(() => {
   // Set a timeout for initial loading - if no progress after 30 seconds, show error
   useEffect(() => {
     const loadingTimeout = setTimeout(() => {
-      if (progressPercentage < 5 && showLoading) {
+      if (showLoading) {
         setLoadingError('Processing is taking longer than expected. You can continue waiting or try again later.');
       }
     }, 30000);
 
     return () => clearTimeout(loadingTimeout);
-  }, [progressPercentage, showLoading]);
+  }, [showLoading]);
 
   // Poll summary status during inactivity, but do not force completion/navigation by timeout.
   useEffect(() => {