Fixed the maintainability code quality issues

Author: Prekshith-Microsoft

src/backend/common/database/cosmosdb.py

@@ -352,10 +352,6 @@ async def update_batch_entry(
             batch["file_count"] = file_count
 
             await self.batch_container.replace_item(item=batch_id, body=batch)
-            # if isinstance(status, ProcessStatus):
-            #     self.logger.info(f"Updated batch {batch_id} to status {status.value}")
-            # else:
-            #     self.logger.info(f"Updated batch {batch_id} to status {status}")
 
             return batch
         except Exception as e:

src/backend/common/storage/blob_azure.py

@@ -52,7 +52,7 @@ async def upload_file(
             raise
         try:
             # Upload the file
-            upload_results = blob_client.upload_blob(  # noqa: F841
+            blob_client.upload_blob(
                 file_content,
                 content_type=content_type,
                 metadata=metadata,

src/backend/sql_agents/convert_script.py

@@ -66,8 +66,7 @@ async def convert_script(
 
         # orchestrate the chat
         current_migration = "No migration"
-        is_complete: bool = False
-        while not is_complete:
+        while True:
             await comms_manager.group_chat.add_chat_message(
                 ChatMessageContent(role=AuthorRole.USER, content=source_script)
             )
@@ -274,10 +273,8 @@ async def convert_script(
                 break
 
             if comms_manager.group_chat.is_complete:
-                is_complete = True
-
-            break
-
+                break
+            
         migrated_query = current_migration
 
         # Handle the case where migration failed and current_migration is None

src/backend/sql_agents/helpers/comms_manager.py

@@ -270,17 +270,3 @@ async def cleanup(self):
 
         except Exception as e:
             self.logger.error("Error during cleanup: %s", str(e))
-
-    def __del__(self):
-        """Destructor to ensure cleanup if not explicitly called."""
-        try:
-            # Only attempt cleanup if there's an active event loop
-            loop = asyncio.get_running_loop()
-            if loop and not loop.is_closed():
-                # Schedule cleanup as a task
-                loop.create_task(self.cleanup())
-        except RuntimeError:
-            # No event loop running, can't clean up asynchronously
-            self.logger.warning("No event loop available for cleanup in destructor")
-        except Exception as e:
-            self.logger.error("Error in destructor cleanup: %s", str(e))

src/backend/sql_agents/tools/src/Program.cs

@@ -1,6 +1,7 @@
 using System;
 using System.Collections.Generic;
 using System.IO;
+using System.Linq;
 using Microsoft.SqlServer.TransactSql.ScriptDom;
 using Newtonsoft.Json;
 
@@ -42,18 +43,14 @@ static void Main(string[] args)
 
             IList<ParseError> errors = ParseSqlQuery(sqlQuery);
 
-            var errorList = new List<Dictionary<string, object>>();
-
-            foreach (var error in errors)
-            {
-                var errorDict = new Dictionary<string, object>
+            var errorList = errors
+                .Select(error => new Dictionary<string, object>
                 {
                     { "Line", error.Line },
                     { "Column", error.Column },
                     { "Error", error.Message }
-                };
-                errorList.Add(errorDict);
-            }
+                })
+                .ToList();
 
             string jsonOutput = JsonConvert.SerializeObject(errorList, Formatting.Indented);
             Console.WriteLine(jsonOutput);

src/frontend/frontend_server.py

@@ -4,7 +4,7 @@
 from dotenv import load_dotenv
 from fastapi import FastAPI
 from fastapi.middleware.cors import CORSMiddleware
-from fastapi.responses import FileResponse, HTMLResponse
+from fastapi.responses import FileResponse
 from fastapi.staticfiles import StaticFiles
 
 # Load environment variables from .env file

src/frontend/src/components/batchHistoryPanel.tsx

@@ -1,6 +1,5 @@
 import React, { useState, useEffect, useRef } from "react";
-
-import { useDispatch, useSelector } from 'react-redux';
+import { useDispatch } from 'react-redux';
 import { Card, Spinner, Tooltip } from "@fluentui/react-components";
 import { useNavigate } from "react-router-dom";
 import ConfirmationDialog from "../commonComponents/ConfirmationDialog/confirmationDialogue";
@@ -21,7 +20,7 @@ interface BatchHistoryItem {
   status: string;
 }
 const HistoryPanel: React.FC<HistoryPanelProps> = ({ isOpen, onClose }) => {
-  const headers = {}
+  const headers = {};
   const [batchHistory, setBatchHistory] = useState<BatchHistoryItem[]>([]);
   const [loading, setLoading] = useState(false);
   const [error, setError] = useState<string | null>(null);
@@ -81,46 +80,6 @@ const HistoryPanel: React.FC<HistoryPanelProps> = ({ isOpen, onClose }) => {
     }
   };
 
-  // Function to categorize batches
-  const categorizeBatches = () => {
-    const now = new Date();
-    const userTimeZone = Intl.DateTimeFormat().resolvedOptions().timeZone;
-
-    // Get start of "Today", "Past 7 days", and "Past 30 days" in LOCAL time
-    const todayStart = new Date(now.getFullYear(), now.getMonth(), now.getDate());
-    const past7DaysStart = new Date(todayStart);
-    const past30DaysStart = new Date(todayStart);
-
-    past7DaysStart.setDate(todayStart.getDate() - 7);
-    past30DaysStart.setDate(todayStart.getDate() - 30);
-
-    const todayBatches: BatchHistoryItem[] = [];
-    const past7DaysBatches: BatchHistoryItem[] = [];
-    const past30DaysBatches: BatchHistoryItem[] = [];
-
-    batchHistory.forEach(batch => {
-      // Convert UTC timestamp to user's local date
-      const updatedAtUTC = new Date(batch.created_at);
-      const updatedAtLocal = new Date(updatedAtUTC.toLocaleString("en-US", { timeZone: userTimeZone }));
-
-      // Extract only the local **date** part for comparison
-      const updatedDate = new Date(updatedAtLocal.getFullYear(), updatedAtLocal.getMonth(), updatedAtLocal.getDate());
-
-      // Categorize based on **exact day comparison**
-      if (updatedDate.getTime() === todayStart.getTime()) {
-        todayBatches.push(batch);
-      } else if (updatedDate.getTime() >= past7DaysStart.getTime()) {
-        past7DaysBatches.push(batch);
-      } else if (updatedDate.getTime() >= past30DaysStart.getTime()) {
-        past30DaysBatches.push(batch);
-      }
-    });
-
-    return { todayBatches, past7DaysBatches, past30DaysBatches };
-  };
-
-  // const { todayBatches, past7DaysBatches, past30DaysBatches } = categorizeBatches();
-
   const deleteBatchFromHistory = (batchId: string) => {
     // Get the current URL path
     const currentPath = window.location.pathname;

src/frontend/src/components/bottomBar.tsx

@@ -1,6 +1,5 @@
 import { Button, Card, Dropdown, DropdownProps, Option } from "@fluentui/react-components"
-import React, { useState } from "react"
-import { useNavigate } from "react-router-dom"
+import React from "react"
 
 // Define possible upload states
 const UploadState = {

src/frontend/src/components/uploadButton.tsx

@@ -68,7 +68,6 @@ const FileUploadZone: React.FC<FileUploadZoneProps> = ({
   const [uploadIntervals, setUploadIntervals] = useState<{ [key: string]: ReturnType<typeof setTimeout> }>({});
   const [showCancelDialog, setShowCancelDialog] = useState(false);
   const [showLogoCancelDialog, setShowLogoCancelDialog] = useState(false);
-  const [uploadState, setUploadState] = useState<'IDLE' | 'UPLOADING' | 'COMPLETED'>('IDLE');
   const [batchId, setBatchId] = useState<string>(uuidv4());
   const [allUploadsComplete, setAllUploadsComplete] = useState(false);
   const [fileLimitExceeded, setFileLimitExceeded] = useState(false);
@@ -98,7 +97,6 @@ const FileUploadZone: React.FC<FileUploadZoneProps> = ({
       }
     }
 
-    setUploadState(newState);
     onUploadStateChange?.(newState);
   }, [uploadingFiles, onUploadStateChange]);
 
@@ -280,7 +278,6 @@ const FileUploadZone: React.FC<FileUploadZoneProps> = ({
   Object.values(uploadIntervals).forEach(interval => clearInterval(interval));
   setUploadIntervals({});
   setUploadingFiles([]);
-  setUploadState('IDLE');
   onUploadStateChange?.('IDLE');
   setShowCancelDialog(false);
   setShowLogoCancelDialog(false);

src/frontend/src/main.jsx

@@ -50,7 +50,7 @@ const Main = () => {
     const baseURL = config.API_URL.replace(/\/api$/, ''); // Remove '/api' if it appears at the end
     console.log('Checking connection to:', baseURL);
     try {
-      const response = await fetch(`${baseURL}/health`);
+      await fetch(`${baseURL}/health`);
     } catch (error) {
       console.error('Error connecting to backend:', error);
     }