Merge pull request #334 from microsoft/code-quality-fix

refactor: Code quality fix

Author: Roopan-Microsoft

src/backend/sql_agents/convert_script.py

@@ -66,8 +66,7 @@ async def convert_script(
 
         # orchestrate the chat
         current_migration = "No migration"
-        is_complete: bool = False
-        while not is_complete:
+        while True:
             await comms_manager.group_chat.add_chat_message(
                 ChatMessageContent(role=AuthorRole.USER, content=source_script)
             )
@@ -274,9 +273,7 @@ async def convert_script(
                 break
 
             if comms_manager.group_chat.is_complete:
-                is_complete = True
-
-            break
+                break
 
         migrated_query = current_migration
 

src/frontend/src/pages/landingPage.tsx

@@ -1,4 +1,4 @@
-import React, { useEffect, useRef, useState } from "react";
+import React, { useEffect, useState } from "react";
 import { useSelector, useDispatch } from "react-redux";
 import { RootState } from "../store/store";
 import { togglePanel, closePanel } from "../slices/historyPanelSlice";

src/frontend/src/pages/modernizationPage.tsx

@@ -31,7 +31,7 @@ import { Light as SyntaxHighlighter } from "react-syntax-highlighter"
 import { vs } from "react-syntax-highlighter/dist/esm/styles/hljs"
 import sql from "react-syntax-highlighter/dist/cjs/languages/hljs/sql"
 import { useNavigate, useParams } from "react-router-dom"
-import { useState, useEffect, useCallback, useRef } from "react"
+import { useState, useEffect, useCallback } from "react"
 import { getApiUrl, headerBuilder } from '../api/config';
 import BatchHistoryPanel from "../components/batchHistoryPanel"
 import PanelRight from "../components/Panels/PanelRight";
@@ -515,9 +515,18 @@ const ModernizationPage = () => {
         if (!selectedFile || !selectedFile.translatedCode) {
           setFileLoading(true);
           const newFileUpdate = await fetchFileFromAPI(selectedFile?.fileId || "");
+          setFiles((prevFiles) =>
+            prevFiles.map((file) =>
+              file.fileId === selectedFile?.fileId
+                ? {
+                    ...file,
+                    code: newFileUpdate.content,
+                    translatedCode: newFileUpdate.translated_content,
+                  }
+                : file
+            )
+          );
           setFileLoading(false);
-        } else {
-
         }
 
       } catch (err) {