refactor: Clean up unused imports and whitespace in multiple files

Author: Harmanpreet-Microsoft

src/backend/api/api_routes.py

@@ -3,8 +3,6 @@
 # Standard library
 import asyncio
 import io
-import logging
-import os
 import zipfile
 from typing import Optional
 

src/backend/api/event_utils.py

@@ -17,7 +17,7 @@
 def _get_telemetry_client():
     """Get or create the Application Insights telemetry client."""
     global _telemetry_client
-    
+
     if _telemetry_client is None:
         connection_string = os.getenv("APPLICATIONINSIGHTS_CONNECTION_STRING")
         if connection_string:
@@ -26,26 +26,26 @@ def _get_telemetry_client():
                 # Format: InstrumentationKey=xxx;IngestionEndpoint=https://...
                 parts = dict(part.split('=', 1) for part in connection_string.split(';') if '=' in part)
                 instrumentation_key = parts.get('InstrumentationKey')
-                
+
                 if instrumentation_key:
                     # Create a synchronous channel for immediate sending
                     sender = SynchronousSender()
                     queue = SynchronousQueue(sender)
                     channel = TelemetryChannel(None, queue)
-                    
+
                     _telemetry_client = TelemetryClient(instrumentation_key, channel)
                     logging.info("Application Insights TelemetryClient initialized successfully")
                 else:
                     logging.error("Could not extract InstrumentationKey from connection string")
             except Exception as e:
                 logging.error(f"Failed to initialize TelemetryClient: {e}")
-    
+
     return _telemetry_client
 
 
 def track_event_if_configured(event_name: str, event_data: dict):
     """Track a custom event to Application Insights customEvents table.
-    
+
     This uses the Application Insights SDK TelemetryClient which properly
     sends custom events to the customEvents table in Application Insights.
     """
@@ -56,11 +56,11 @@ def track_event_if_configured(event_name: str, event_data: dict):
             if client:
                 # Convert all values to strings to ensure compatibility
                 properties = {k: str(v) for k, v in event_data.items()}
-                
+
                 # Track the custom event
                 client.track_event(event_name, properties=properties)
                 client.flush()  # Ensure immediate sending
-                
+
                 logging.debug(f"Tracked custom event: {event_name} with data: {event_data}")
             else:
                 logging.warning("TelemetryClient not available, custom event not tracked")

src/backend/app.py

@@ -5,7 +5,6 @@
 
 from api.api_routes import router as backend_router
 
-from azure.monitor.opentelemetry import configure_azure_monitor
 from azure.monitor.opentelemetry.exporter import AzureMonitorLogExporter, AzureMonitorTraceExporter
 
 from common.config.config import app_config
@@ -142,25 +141,25 @@ def create_app() -> FastAPI:
         # SOLUTION: Use manual telemetry setup instead of configure_azure_monitor
         # This gives us precise control over what gets instrumented, avoiding interference
         # with Semantic Kernel's async generators while still tracking Azure SDK calls
-        
+
         # Set up Azure Monitor exporter for traces
         azure_trace_exporter = AzureMonitorTraceExporter(connection_string=instrumentation_key)
-        
+
         # Create a tracer provider and add the Azure Monitor exporter
         tracer_provider = TracerProvider()
         tracer_provider.add_span_processor(BatchSpanProcessor(azure_trace_exporter))
-        
+
         # Set the global tracer provider
         trace.set_tracer_provider(tracer_provider)
 
         # Set up Azure Monitor exporter for logs (appears in traces table)
         azure_log_exporter = AzureMonitorLogExporter(connection_string=instrumentation_key)
-        
+
         # Create a logger provider and add the Azure Monitor exporter
         logger_provider = LoggerProvider()
         logger_provider.add_log_record_processor(BatchLogRecordProcessor(azure_log_exporter))
         set_logger_provider(logger_provider)
-        
+
         # Attach OpenTelemetry handler to Python's root logger
         handler = LoggingHandler(logger_provider=logger_provider)
         logging.getLogger().addHandler(handler)
@@ -172,13 +171,13 @@ def create_app() -> FastAPI:
             excluded_urls="socket,ws",  # Exclude WebSocket URLs to reduce noise
             tracer_provider=tracer_provider
         )
-        
+
         # Optional: Add manual spans in your code for Azure SDK operations using:
         # from opentelemetry import trace
         # tracer = trace.get_tracer(__name__)
         # with tracer.start_as_current_span("operation_name"):
         #     # your Azure SDK call here
-        
+
         logger.logger.info("Application Insights configured with selective instrumentation")
         logger.logger.info("✓ FastAPI HTTP tracing enabled")
         logger.logger.info("✓ Python logging export to Application Insights enabled")
@@ -188,7 +187,6 @@ def create_app() -> FastAPI:
     else:
         logger.logger.warning("No Application Insights connection string found. Telemetry disabled.")
 
-
     # Include routers with /api prefix
     app.include_router(backend_router, prefix="/api", tags=["backend"])
     # app.include_router(agents_router, prefix="/api/agents", tags=["agents"])

src/backend/common/telemetry/telemetry_helper.py

@@ -6,16 +6,17 @@
 
 Example usage:
     from common.telemetry.telemetry_helper import trace_operation
-    
+
     @trace_operation("cosmosdb_query")
     async def query_items(self, query: str):
         # Your CosmosDB query here
         pass
 """
 
+import asyncio
 import functools
 from contextlib import asynccontextmanager, contextmanager
-from typing import Any, Optional
+from typing import Optional
 
 from opentelemetry import trace
 from opentelemetry.trace import Status, StatusCode
@@ -28,11 +29,11 @@ def get_tracer(name: str = __name__):
 
 def trace_operation(operation_name: str, attributes: Optional[dict] = None):
     """Decorator to add telemetry span to a function or method.
-    
+
     Args:
         operation_name: Name of the operation for the span
         attributes: Optional dictionary of attributes to add to the span
-        
+
     Example:
         @trace_operation("batch_processing", {"service": "sql_agents"})
         async def process_batch(batch_id: str):
@@ -48,10 +49,10 @@ async def async_wrapper(*args, **kwargs):
                 if attributes:
                     for key, value in attributes.items():
                         span.set_attribute(key, str(value))
-                
+
                 # Add function arguments as attributes (optional, for debugging)
                 span.set_attribute("function", func.__name__)
-                
+
                 try:
                     result = await func(*args, **kwargs)
                     span.set_status(Status(StatusCode.OK))
@@ -60,17 +61,17 @@ async def async_wrapper(*args, **kwargs):
                     span.record_exception(e)
                     span.set_status(Status(StatusCode.ERROR, str(e)))
                     raise
-        
+
         @functools.wraps(func)
         def sync_wrapper(*args, **kwargs):
             tracer = get_tracer(func.__module__)
             with tracer.start_as_current_span(operation_name) as span:
                 if attributes:
                     for key, value in attributes.items():
                         span.set_attribute(key, str(value))
-                
+
                 span.set_attribute("function", func.__name__)
-                
+
                 try:
                     result = func(*args, **kwargs)
                     span.set_status(Status(StatusCode.OK))
@@ -79,24 +80,24 @@ def sync_wrapper(*args, **kwargs):
                     span.record_exception(e)
                     span.set_status(Status(StatusCode.ERROR, str(e)))
                     raise
-        
+
         # Return appropriate wrapper based on function type
         if asyncio.iscoroutinefunction(func):
             return async_wrapper
         else:
             return sync_wrapper
-    
+
     return decorator
 
 
 @asynccontextmanager
 async def trace_context(operation_name: str, attributes: Optional[dict] = None):
     """Async context manager for adding telemetry span to a code block.
-    
+
     Args:
         operation_name: Name of the operation for the span
         attributes: Optional dictionary of attributes to add to the span
-        
+
     Example:
         async with trace_context("cosmosdb_batch_query", {"batch_id": batch_id}):
             results = await database.query_items(query)
@@ -107,7 +108,7 @@ async def trace_context(operation_name: str, attributes: Optional[dict] = None):
         if attributes:
             for key, value in attributes.items():
                 span.set_attribute(key, str(value))
-        
+
         try:
             yield span
             span.set_status(Status(StatusCode.OK))
@@ -120,11 +121,11 @@ async def trace_context(operation_name: str, attributes: Optional[dict] = None):
 @contextmanager
 def trace_sync_context(operation_name: str, attributes: Optional[dict] = None):
     """Sync context manager for adding telemetry span to a code block.
-    
+
     Args:
         operation_name: Name of the operation for the span
         attributes: Optional dictionary of attributes to add to the span
-        
+
     Example:
         with trace_sync_context("blob_upload", {"file_name": file_name}):
             blob_client.upload_blob(data)
@@ -134,7 +135,7 @@ def trace_sync_context(operation_name: str, attributes: Optional[dict] = None):
         if attributes:
             for key, value in attributes.items():
                 span.set_attribute(key, str(value))
-        
+
         try:
             yield span
             span.set_status(Status(StatusCode.OK))
@@ -146,17 +147,14 @@ def trace_sync_context(operation_name: str, attributes: Optional[dict] = None):
 
 def add_span_attributes(attributes: dict):
     """Add attributes to the current span.
-    
+
     Args:
         attributes: Dictionary of attributes to add
-        
+
     Example:
         add_span_attributes({"user_id": user_id, "batch_id": batch_id})
     """
     span = trace.get_current_span()
     if span and span.is_recording():
         for key, value in attributes.items():
             span.set_attribute(key, str(value))
-
-
-import asyncio

src/backend/sql_agents/process_batch.py

@@ -17,7 +17,7 @@
 )
 from common.services.batch_service import BatchService
 from common.storage.blob_factory import BlobStorageFactory
-from common.telemetry import trace_context, add_span_attributes
+from common.telemetry import trace_context
 
 from fastapi import HTTPException
 
@@ -40,8 +40,8 @@ async def process_batch_async(
     """Central batch processing function to process each file in the batch"""
     # Add telemetry span for the entire batch processing operation
     async with trace_context("process_batch", {
-        "batch_id": batch_id, 
-        "convert_from": convert_from, 
+        "batch_id": batch_id,
+        "convert_from": convert_from,
         "convert_to": convert_to
     }):
         logger.info("Processing batch: %s", batch_id)