pylint issues fix

Author: Ayaz-Microsoft

src/backend/pyproject.toml

@@ -45,4 +45,10 @@ exclude_lines = [
     "raise NotImplementedError",
     "if __name__ == .__main__.:",
     "if TYPE_CHECKING:",
-]
+]
+
+[tool.pylint."messages control"]
+# C0411 disabled because flake8-import-order requires application imports before
+# third-party imports, which conflicts with pylint's default order. Since flake8
+# is used in CI, we follow its convention.
+disable = ["C0411"]

src/tests/backend/api/api_routes_test.py

@@ -1,30 +1,28 @@
 """Tests for API routes module."""
+# pylint: disable=redefined-outer-name,unused-argument
 
-import io
-import json
 import uuid
 from unittest.mock import AsyncMock, MagicMock, patch
 
-import pytest
-from fastapi import FastAPI, HTTPException
-from fastapi.testclient import TestClient
-from httpx import ASGITransport, AsyncClient
-
 from backend.api.api_routes import (
-    record_exception_to_trace,
-    router,
-    start_processing,
+    delete_all_details,
+    delete_batch_details,
+    delete_file_details,
     download_files,
     get_batch_status,
     get_batch_summary,
-    upload_file,
     get_file_details,
-    delete_batch_details,
-    delete_file_details,
-    delete_all_details,
     list_batch_history,
+    record_exception_to_trace,
+    router,
+    start_processing,
+    upload_file,
 )
 
+from fastapi import FastAPI, HTTPException
+
+import pytest
+
 
 @pytest.fixture
 def test_app():
@@ -118,7 +116,7 @@ async def test_start_processing_success(self, mock_process_batch, mock_close_con
         })
 
         result = await start_processing(mock_request)
-        
+
         assert result["batch_id"] == batch_id
         assert result["status"] == "Processing completed"
         mock_process_batch.assert_called_once()
@@ -154,7 +152,7 @@ async def test_download_files_success(self, mock_batch_service, mock_track_event
         ]
 
         response = await download_files(batch_id)
-        
+
         assert response.media_type == "application/zip"
         assert "Content-Disposition" in response.headers
 
@@ -192,7 +190,7 @@ async def test_get_batch_status_success(self, mock_batch_service, mock_auth_user
         mock_batch_service.get_batch.return_value = {"batch_id": batch_id, "status": "completed"}
 
         result = await get_batch_status(mock_request, batch_id)
-        
+
         assert result["batch_id"] == batch_id
 
     @pytest.mark.asyncio
@@ -241,7 +239,7 @@ async def test_get_batch_summary_success(self, mock_batch_service, mock_auth_use
         mock_batch_service.get_batch_summary.return_value = {"total_files": 5}
 
         result = await get_batch_summary(mock_request, batch_id)
-        
+
         assert result["total_files"] == 5
 
     @pytest.mark.asyncio
@@ -267,7 +265,7 @@ async def test_upload_file_success(self, mock_batch_service, mock_auth_user, moc
         mock_batch_service.upload_file_to_batch.return_value = {"file_id": "test-file-id"}
 
         result = await upload_file(mock_request, mock_file, batch_id)
-        
+
         assert result["file_id"] == "test-file-id"
 
     @pytest.mark.asyncio
@@ -307,7 +305,7 @@ async def test_get_file_details_success(self, mock_batch_service, mock_auth_user
         mock_batch_service.get_file_report.return_value = {"file_id": file_id}
 
         result = await get_file_details(mock_request, file_id)
-        
+
         assert result["file_id"] == file_id
 
     @pytest.mark.asyncio
@@ -342,7 +340,7 @@ async def test_delete_batch_success(self, mock_batch_service, mock_auth_user, mo
         mock_batch_service.delete_batch_and_files.return_value = True
 
         result = await delete_batch_details(mock_request, batch_id)
-        
+
         assert result["message"] == "Batch deleted successfully"
 
     @pytest.mark.asyncio
@@ -367,7 +365,7 @@ async def test_delete_file_success(self, mock_batch_service, mock_auth_user, moc
         mock_batch_service.delete_file.return_value = True
 
         result = await delete_file_details(mock_request, file_id)
-        
+
         assert result["message"] == "File deleted successfully"
 
     @pytest.mark.asyncio
@@ -391,7 +389,7 @@ async def test_delete_all_success(self, mock_batch_service, mock_auth_user, mock
         mock_batch_service.delete_all_from_storage_cosmos.return_value = True
 
         result = await delete_all_details(mock_request)
-        
+
         assert result["message"] == "All user data deleted successfully"
 
     @pytest.mark.asyncio
@@ -415,7 +413,7 @@ async def test_list_batch_history_success(self, mock_batch_service, mock_auth_us
         mock_batch_service.get_batch_history.return_value = [{"batch_id": "test"}]
 
         result = await list_batch_history(mock_request)
-        
+
         assert len(result) == 1
 
     @pytest.mark.asyncio
@@ -424,8 +422,8 @@ async def test_list_batch_history_with_pagination(self, mock_batch_service, mock
         mock_request = MagicMock()
         mock_batch_service.get_batch_history.return_value = [{"batch_id": "test"}]
 
-        result = await list_batch_history(mock_request, offset=10, limit=5)
-        
+        await list_batch_history(mock_request, offset=10, limit=5)
+
         mock_batch_service.get_batch_history.assert_called_once()
 
     @pytest.mark.asyncio
@@ -435,5 +433,5 @@ async def test_list_batch_history_empty(self, mock_batch_service, mock_auth_user
         mock_batch_service.get_batch_history.return_value = None
 
         result = await list_batch_history(mock_request)
-        
+
         assert result.status_code == 404

src/tests/backend/api/event_utils_test.py

@@ -1,9 +1,7 @@
 """Tests for event_utils module."""
 
 import os
-from unittest.mock import patch, MagicMock
-
-import pytest
+from unittest.mock import patch
 
 from backend.api.event_utils import track_event_if_configured
 
@@ -16,7 +14,7 @@ def test_track_event_with_instrumentation_key(self):
         with patch.dict(os.environ, {"APPLICATIONINSIGHTS_CONNECTION_STRING": "test-key"}):
             with patch("backend.api.event_utils.track_event") as mock_track:
                 track_event_if_configured("TestEvent", {"key": "value"})
-                
+
                 mock_track.assert_called_once_with("TestEvent", {"key": "value"})
 
     def test_track_event_without_instrumentation_key(self):
@@ -27,7 +25,7 @@ def test_track_event_without_instrumentation_key(self):
             with patch("backend.api.event_utils.track_event") as mock_track:
                 with patch("backend.api.event_utils.logging.warning") as mock_warning:
                     track_event_if_configured("TestEvent", {"key": "value"})
-                    
+
                     mock_track.assert_not_called()
                     mock_warning.assert_called_once()
 
@@ -36,7 +34,7 @@ def test_track_event_with_empty_data(self):
         with patch.dict(os.environ, {"APPLICATIONINSIGHTS_CONNECTION_STRING": "test-key"}):
             with patch("backend.api.event_utils.track_event") as mock_track:
                 track_event_if_configured("TestEvent", {})
-                
+
                 mock_track.assert_called_once_with("TestEvent", {})
 
     def test_track_event_with_complex_data(self):
@@ -49,7 +47,7 @@ def test_track_event_with_complex_data(self):
                     "status": "completed",
                     "nested": {"key": "value"},
                 }
-                
+
                 track_event_if_configured("ComplexEvent", complex_data)
-                
+
                 mock_track.assert_called_once_with("ComplexEvent", complex_data)

src/tests/backend/api/status_updates_test.py

@@ -1,18 +1,16 @@
 """Tests for status_updates module."""
 
-import asyncio
 from unittest.mock import AsyncMock, MagicMock, patch
 
-import pytest
-
 from backend.api.status_updates import (
     ConnectionManager,
     app_connection_manager,
-    send_status_update_async,
-    send_status_update,
     close_connection,
+    send_status_update,
+    send_status_update_async,
 )
-from backend.common.models.api import FileProcessUpdate, ProcessStatus, FileResult
+
+import pytest
 
 
 class TestConnectionManager:
@@ -21,15 +19,15 @@ class TestConnectionManager:
     def test_init(self):
         """Test ConnectionManager initialization."""
         manager = ConnectionManager()
-        assert manager.connections == {}
+        assert not manager.connections
 
     def test_add_connection(self):
         """Test adding a connection."""
         manager = ConnectionManager()
         mock_websocket = MagicMock()
-        
+
         manager.add_connection("batch-1", mock_websocket)
-        
+
         assert "batch-1" in manager.connections
         assert manager.connections["batch-1"] == mock_websocket
 
@@ -38,15 +36,15 @@ def test_remove_connection(self):
         manager = ConnectionManager()
         mock_websocket = MagicMock()
         manager.add_connection("batch-1", mock_websocket)
-        
+
         manager.remove_connection("batch-1")
-        
+
         assert "batch-1" not in manager.connections
 
     def test_remove_nonexistent_connection(self):
         """Test removing a connection that doesn't exist."""
         manager = ConnectionManager()
-        
+
         # Should not raise an error
         manager.remove_connection("nonexistent")
 
@@ -55,17 +53,17 @@ def test_get_connection(self):
         manager = ConnectionManager()
         mock_websocket = MagicMock()
         manager.add_connection("batch-1", mock_websocket)
-        
+
         result = manager.get_connection("batch-1")
-        
+
         assert result == mock_websocket
 
     def test_get_nonexistent_connection(self):
         """Test getting a connection that doesn't exist."""
         manager = ConnectionManager()
-        
+
         result = manager.get_connection("nonexistent")
-        
+
         assert result is None
 
 
@@ -76,22 +74,22 @@ class TestSendStatusUpdateAsync:
     async def test_send_status_update_async_with_connection(self):
         """Test sending status update when connection exists."""
         mock_websocket = AsyncMock()
-        
+
         status = MagicMock()
         status.batch_id = "batch-1"
-        
+
         with patch.object(app_connection_manager, 'get_connection', return_value=mock_websocket):
             with patch("json.dumps", return_value='{"batch_id": "batch-1"}'):
                 await send_status_update_async(status)
-                
+
                 mock_websocket.send_text.assert_called_once()
 
     @pytest.mark.asyncio
     async def test_send_status_update_async_no_connection(self):
         """Test sending status update when no connection exists."""
         status = MagicMock()
         status.batch_id = "batch-1"
-        
+
         with patch.object(app_connection_manager, 'get_connection', return_value=None):
             # Should not raise an error
             await send_status_update_async(status)
@@ -104,34 +102,34 @@ def test_send_status_update_with_connection(self):
         """Test sending status update synchronously when connection exists."""
         mock_websocket = MagicMock()
         mock_loop = MagicMock()
-        
+
         status = MagicMock()
         status.batch_id = "batch-1"
-        
+
         with patch.object(app_connection_manager, 'get_connection', return_value=mock_websocket):
             with patch('backend.api.status_updates.asyncio.get_event_loop', return_value=mock_loop):
                 with patch('backend.api.status_updates.asyncio.run_coroutine_threadsafe') as mock_run:
                     with patch('backend.api.status_updates.json.dumps', return_value='{"batch_id": "batch-1"}'):
                         send_status_update(status)
-                        
+
                         mock_run.assert_called_once()
 
     def test_send_status_update_no_connection(self):
         """Test sending status update when no connection exists."""
         status = MagicMock()
         status.batch_id = "batch-1"
-        
+
         with patch.object(app_connection_manager, 'get_connection', return_value=None):
             # Should not raise an error
             send_status_update(status)
 
     def test_send_status_update_exception(self):
         """Test sending status update when exception occurs."""
         mock_websocket = MagicMock()
-        
+
         status = MagicMock()
         status.batch_id = "batch-1"
-        
+
         with patch.object(app_connection_manager, 'get_connection', return_value=mock_websocket):
             with patch('backend.api.status_updates.asyncio.get_event_loop', side_effect=RuntimeError("No event loop")):
                 # Should handle exception gracefully
@@ -146,13 +144,13 @@ async def test_close_connection_with_connection(self):
         """Test closing a connection that exists."""
         mock_websocket = MagicMock()
         mock_loop = MagicMock()
-        
+
         with patch.object(app_connection_manager, 'get_connection', return_value=mock_websocket):
             with patch.object(app_connection_manager, 'remove_connection') as mock_remove:
                 with patch('asyncio.get_event_loop', return_value=mock_loop):
                     with patch('asyncio.run_coroutine_threadsafe'):
                         await close_connection("batch-1")
-                        
+
                         mock_remove.assert_called_once_with("batch-1")
 
     @pytest.mark.asyncio
@@ -161,6 +159,6 @@ async def test_close_connection_no_connection(self):
         with patch.object(app_connection_manager, 'get_connection', return_value=None):
             with patch.object(app_connection_manager, 'remove_connection') as mock_remove:
                 await close_connection("batch-1")
-                
+
                 # Should still call remove_connection
                 mock_remove.assert_called_once_with("batch-1")

src/tests/backend/app_test.py

@@ -1,3 +1,6 @@
+# pylint: disable=redefined-outer-name
+"""Tests for the FastAPI application."""
+
 from backend.app import create_app
 
 from fastapi import FastAPI

src/tests/backend/sql_agents/__init__.py

@@ -1 +1 @@
-# sql_agents tests package
+# sql_agents tests package\n# pylint: disable=duplicate-code