fixed pylint issues

Author: Harsh-Microsoft

.github/workflows/test-automation.yml

@@ -13,7 +13,8 @@ on:
   workflow_dispatch:
 
 env:
-    url: ${{ vars.CODEGEN_WEB_URL }}
+    # url: ${{ vars.CODEGEN_WEB_URL }}
+    url: https://cm3ydcorjzov5mfrontend.greencliff-0258c52e.uksouth.azurecontainerapps.io
     accelerator_name: "Code Modernization"
 
 jobs:

TestAutomation/base/__init__.py

@@ -1 +0,0 @@
-from . import base

TestAutomation/base/base.py

@@ -1,16 +1,10 @@
-from config.constants import *
-from dotenv import load_dotenv
-
-
 class BasePage:
     def __init__(self, page):
         self.page = page
 
-    def scroll_into_view(self,locator):
+    def scroll_into_view(self, locator):
         reference_list = locator
-        locator.nth(reference_list.count()-1).scroll_into_view_if_needed()
+        locator.nth(reference_list.count() - 1).scroll_into_view_if_needed()
 
-    def is_visible(self,locator):
+    def is_visible(self, locator):
         locator.is_visible()
-
-    

TestAutomation/config/constants.py

@@ -1,12 +1,8 @@
-from dotenv import load_dotenv
 import os
-import json
+
+from dotenv import load_dotenv
 
 load_dotenv()
-URL = os.getenv('url')
-if URL.endswith('/'):
+URL = os.getenv("url")
+if URL.endswith("/"):
     URL = URL[:-1]
-
-
-
-

TestAutomation/pages/HomePage.py

@@ -1,6 +1,9 @@
+import os.path
+
 from base.base import BasePage
+
 from playwright.sync_api import expect
-import os.path
+
 
 class HomePage(BasePage):
     TITLE_TEXT = "//h1[normalize-space()='Modernize your code']"
@@ -15,8 +18,6 @@ class HomePage(BasePage):
     SUMMARY = "//span[normalize-space()='Summary']"
     FILE_PROCESSED_MSG = "//span[normalize-space()='3 files processed successfully']"
 
-
-
     def __init__(self, page):
         self.page = page
 
@@ -27,28 +28,28 @@ def upload_files(self):
         with self.page.expect_file_chooser() as fc_info:
             self.page.locator(self.BROWSE_FILES).click()
             self.page.wait_for_timeout(5000)
-            self.page.wait_for_load_state('networkidle')
+            self.page.wait_for_load_state("networkidle")
         file_chooser = fc_info.value
         current_working_dir = os.getcwd()
-        file_path1 = os.path.join(current_working_dir,"testdata/q1_informix.sql")
-        file_path2 = os.path.join(current_working_dir,"testdata/f1.sql")
-        file_path3 = os.path.join(current_working_dir,"testdata/f2.sql")
+        file_path1 = os.path.join(current_working_dir, "testdata/q1_informix.sql")
+        file_path2 = os.path.join(current_working_dir, "testdata/f1.sql")
+        file_path3 = os.path.join(current_working_dir, "testdata/f2.sql")
         file_chooser.set_files([file_path1, file_path2, file_path3])
         self.page.wait_for_timeout(10000)
-        self.page.wait_for_load_state('networkidle')
+        self.page.wait_for_load_state("networkidle")
         expect(self.page.locator(self.SUCCESS_MSG)).to_be_visible()
 
     def upload_unsupported_files(self):
         with self.page.expect_file_chooser() as fc_info:
             self.page.locator(self.BROWSE_FILES).click()
             self.page.wait_for_timeout(5000)
-            self.page.wait_for_load_state('networkidle')
+            self.page.wait_for_load_state("networkidle")
         file_chooser = fc_info.value
         current_working_dir = os.getcwd()
-        file_path = os.path.join(current_working_dir,"testdata/invalid.py")
+        file_path = os.path.join(current_working_dir, "testdata/invalid.py")
         file_chooser.set_files([file_path])
         self.page.wait_for_timeout(4000)
-        self.page.wait_for_load_state('networkidle')
+        self.page.wait_for_load_state("networkidle")
         expect(self.page.locator(self.TRANSLATE_BTN)).to_be_disabled()
 
     def validate_translate(self):
@@ -72,16 +73,3 @@ def validate_download_files(self):
         self.page.locator(self.RETURN_HOME).click()
         self.page.wait_for_timeout(3000)
         expect(self.page.locator(self.TITLE_TEXT)).to_be_visible()
-
-    
-
-
-
-
-
-        
-
-    
-
-
-  

TestAutomation/pages/__init__.py

@@ -1,2 +0,0 @@
-from. import loginPage
-from. import HomePage

TestAutomation/pages/loginPage.py

@@ -13,12 +13,12 @@ class LoginPage(BasePage):
     def __init__(self, page):
         self.page = page
 
-    def authenticate(self, username,password):
+    def authenticate(self, username, password):
         # login with username and password in web url
         self.page.locator(self.EMAIL_TEXT_BOX).fill(username)
         self.page.locator(self.NEXT_BUTTON).click()
         # Wait for the password input field to be available and fill it
-        self.page.wait_for_load_state('networkidle')
+        self.page.wait_for_load_state("networkidle")
         # Enter password
         self.page.locator(self.PASSWORD_TEXT_BOX).fill(password)
         # Click on SignIn button
@@ -33,4 +33,4 @@ def authenticate(self, username,password):
             self.page.locator(self.YES_BUTTON).click()
             self.page.wait_for_timeout(10000)
         # Wait for the "Articles" button to be available and click it
-        self.page.wait_for_load_state('networkidle')
+        self.page.wait_for_load_state("networkidle")

TestAutomation/testdata/invalid.py

@@ -1 +0,0 @@
-from . import base

TestAutomation/tests/conftest.py

@@ -1,9 +1,12 @@
-from pathlib import Path
-import pytest
+import os
+
+from config.constants import URL
+
 from playwright.sync_api import sync_playwright
-from config.constants import *
-from py.xml import html # type: ignore
 
+from py.xml import html  # type: ignore
+
+import pytest
 
 
 @pytest.fixture(scope="session")
@@ -16,7 +19,7 @@ def login_logout():
         page = context.new_page()
         # Navigate to the login URL
         page.goto(URL, wait_until="domcontentloaded")
-        
+
         yield page
         # perform close the browser
         browser.close()
@@ -31,8 +34,12 @@ def pytest_html_report_title(report):
 def pytest_html_results_table_header(cells):
     cells.insert(1, html.th("Description"))
 
+
 def pytest_html_results_table_row(report, cells):
-    cells.insert(1, html.td(report.description if hasattr(report, "description") else ""))
+    cells.insert(
+        1, html.td(report.description if hasattr(report, "description") else "")
+    )
+
 
 # Add logs and docstring to report
 @pytest.hookimpl(hookwrapper=True)
@@ -41,6 +48,5 @@ def pytest_runtest_makereport(item, call):
     report = outcome.get_result()
     report.description = str(item.function.__doc__)
     os.makedirs("logs", exist_ok=True)
-    extra = getattr(report, 'extra', [])
+    extra = getattr(report, "extra", [])
     report.extra = extra
-

TestAutomation/tests/test_codegen_gp_tc.py

@@ -1,14 +1,17 @@
-from pages.HomePage import HomePage
-from config.constants import *
 import logging
-import pytest
 import time
 
+from pages.HomePage import HomePage
+
+import pytest
+
+
 logger = logging.getLogger(__name__)
 
+
 @pytest.mark.testcase_id("TC001")
 def test_CodeGen_Golden_path_test(login_logout):
-    """Validate Golden path test case for Modernize your code Accelerator """
+    """Validate Golden path test case for Modernize your code Accelerator"""
     page = login_logout
     home_page = HomePage(page)
     logger.info("Step 1: Validate home page is loaded.")