Merge pull request #102 from microsoft/psl-bugbash-feedback

fix: fixes for the Bug Bash feedback

Author: Roopan-Microsoft

.devcontainer/devcontainer.json

@@ -3,19 +3,26 @@
     "image": "mcr.microsoft.com/devcontainers/python:3.11-bullseye",
     "forwardPorts": [50505],
     "features": {
-        "ghcr.io/azure/azure-dev/azd:latest": {}
+        "ghcr.io/azure/azure-dev/azd:latest": {},
+        "ghcr.io/devcontainers/features/azure-cli:1": {
+			"installBicep": true,
+			"version": "latest",
+			"bicepVersion": "latest"
+		}
     },
     "customizations": {
         "vscode": {
             "extensions": [
                 "ms-azuretools.azure-dev",
+                "ms-azuretools.vscode-azcli",
                 "ms-azuretools.vscode-bicep",
                 "ms-python.python",
                 "ms-toolsai.jupyter",
                 "GitHub.vscode-github-actions"
             ]
         }
     },
+    "postCreateCommand": "sudo chmod +x ./scripts/quota_check_params.sh",
     "postStartCommand": "git pull origin main && python3 -m pip install -r ./src/frontend/requirements.txt && python3 -m pip install -r ./src/backend/requirements.txt",
     "remoteUser": "vscode",
     "hostRequirements": {

azure.yaml

@@ -5,19 +5,19 @@ name: modernize-your-code-solution-accelerator
 metadata:
     template: modernize-your-code-solution-accelerator@1.0
 parameters:
-  AiLocation:
+  AzureAiServiceLocation:
     type: string
     default: japaneast
-  ResourcePrefix:
+  Prefix:
     type: string
-    default: bs-azdtest
+    default: azdtemp
   baseUrl:
     type: string
     default: 'https://raw.githubusercontent.com/microsoft/Modernize-your-code-solution-accelerator'
 deployment:
   mode: Incremental
   template: ./infra/main.bicep  # Path to the main.bicep file inside the 'deployment' folder
-  prameters:
-    AiLocation: ${{ parameters.AiLocation }}
-    ResourcePrefix: ${{ parameters.ResourcePrefix }}
+  parameters:
+    AzureAiServiceLocation: ${{ parameters.AzureAiServiceLocation }}
+    Prefix: ${{ parameters.Prefix }}
     baseUrl: ${{ parameters.baseUrl }}

docs/CustomizingAzdParameters.md

@@ -5,16 +5,22 @@ By default this template will use the environment name as the prefix to prevent
 
 > To override any of the parameters, run `azd env set <key> <value>` before running `azd up`. On the first azd command, it will prompt you for the environment name. Be sure to choose 3-20 characters alphanumeric unique name. 
 
+Change the Content Understanding Location (allowed values: Sweden Central, Australia East)
+
+```shell
+azd env set AZURE_ENV_CU_LOCATION 'swedencentral'
+```
+
 Change the Model Deployment Type (allowed values: Standard, GlobalStandard)
 
 ```shell
 azd env set AZURE_ENV_MODEL_DEPLOYMENT_TYPE Standard
 ```
 
-Set the Model Name (allowed values: gpt-4)
+Set the Model Name (allowed values: gpt-4o)
 
 ```shell
-azd env set AZURE_ENV_MODEL_NAME gpt-4
+azd env set AZURE_ENV_MODEL_NAME gpt-4o
 ```
 
 Change the Model Capacity (choose a number based on available GPT model capacity in your subscription)

docs/EXAMPLE-CustomizingAzdParameters.md

@@ -3,7 +3,7 @@
 By default this template will use the environment name as the prefix to prevent naming collisions within Azure. The parameters below show the default values. You only need to run the statements below if you need to change the values. 
 
 
-> To override any of the parameters, run `azd env set <key> <value>` before running `azd up`. On the first azd command, it will prompt you for the environment name. Be sure to choose 3-20 charaters alphanumeric unique name. 
+> To override any of the parameters, run `azd env set <key> <value>` before running `azd up`. On the first azd command, it will prompt you for the environment name. Be sure to choose 3-20 characters alphanumeric unique name. 
 
 Change the Content Understanding Location (allowed values: Sweden Central, Australia East)
 
@@ -17,10 +17,10 @@ Change the Model Deployment Type (allowed values: Standard, GlobalStandard)
 azd env set AZURE_ENV_MODEL_DEPLOYMENT_TYPE GlobalStandard
 ```
 
-Set the Model Name (allowed values: gpt-4o-mini, gpt-4o, gpt-4)
+Set the Model Name (allowed values: gpt-4o)
 
 ```shell
-azd env set AZURE_ENV_MODEL_NAME gpt-4o-mini
+azd env set AZURE_ENV_MODEL_NAME gpt-4o
 ```
 
 Change the Model Capacity (choose a number based on available GPT model capacity in your subscription)