fix: conditionally set exc_info in AppLogger.error based on active exception context

Agent-Logs-Url: https://github.com/microsoft/Modernize-your-code-solution-accelerator/sessions/9a6c2020-0f93-4936-bc01-9d333c0444b2

Co-authored-by: Abdul-Microsoft <192570837+Abdul-Microsoft@users.noreply.github.com>

Author: Copilot

src/backend/common/logger/app_logger.py

@@ -1,5 +1,6 @@
 import json
 import logging
+import sys
 from typing import Any
 
 
@@ -43,7 +44,9 @@ def info(self, message: Any, **kwargs) -> None:
     def warning(self, message: Any, **kwargs) -> None:
         self.logger.warning(self._format_message(message, **kwargs))
 
-    def error(self, message: Any, exc_info=True, **kwargs) -> None:
+    def error(self, message: Any, exc_info=None, **kwargs) -> None:
+        if exc_info is None:
+            exc_info = sys.exc_info()[0] is not None
         self.logger.error(self._format_message(message, **kwargs), exc_info=exc_info)
 
     def critical(self, message: Any, **kwargs) -> None:

src/tests/backend/common/logger/app_logger_test.py

@@ -76,6 +76,38 @@ def test_error_log(logger_instance):
         log_json = json.loads(mock_error.call_args[0][0])
         assert log_json["message"] == "Error log"
         assert log_json["context"]["error_code"] == 500
+        # Called outside an exception context, so exc_info should be False
+        assert mock_error.call_args[1]["exc_info"] is False
+
+
+def test_error_log_with_active_exception(logger_instance):
+    with patch.object(logger_instance.logger, "error") as mock_error:
+        try:
+            raise ValueError("test error")
+        except ValueError:
+            logger_instance.error("Error log inside exception")
+        mock_error.assert_called_once()
+        # Called inside an exception context, so exc_info should be True
+        assert mock_error.call_args[1]["exc_info"] is True
+
+
+def test_error_log_without_active_exception(logger_instance):
+    with patch.object(logger_instance.logger, "error") as mock_error:
+        logger_instance.error("Error log outside exception")
+        mock_error.assert_called_once()
+        # Called outside an exception context, so exc_info should be False
+        assert mock_error.call_args[1]["exc_info"] is False
+
+
+def test_error_log_explicit_exc_info_override(logger_instance):
+    with patch.object(logger_instance.logger, "error") as mock_error:
+        try:
+            raise ValueError("test error")
+        except ValueError:
+            logger_instance.error("Suppressed traceback", exc_info=False)
+        mock_error.assert_called_once()
+        # Explicit exc_info=False should override auto-detection even inside an exception context
+        assert mock_error.call_args[1]["exc_info"] is False
 
 
 def test_critical_log(logger_instance):