Skip to content

Commit 3a41d94

Browse files
Resolved copilot review comments
1 parent 20f52f0 commit 3a41d94

2 files changed

Lines changed: 3 additions & 7 deletions

File tree

src/tests/backend/common/database/test_database_base.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -494,17 +494,13 @@ async def get_team_agent(self, team_id, agent_name): return None
494494

495495
database = MockDatabase()
496496

497-
exception_raised = False
498-
try:
497+
with pytest.raises(ValueError, match="Test exception"):
499498
async with database:
500499
assert database.initialized is True
501500
# Raise an exception to test cleanup
502501
raise ValueError("Test exception")
503-
except ValueError:
504-
exception_raised = True
505502

506503
# Even with exception, close should have been called
507-
assert exception_raised is True
508504
assert database.closed is True
509505

510506

src/tests/backend/v4/config/test_settings.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,7 @@ async def cancel_task():
347347
_ = await task
348348

349349
await cancel_task_handle
350-
self.assertTrue(cancel_task_handle.done())
350+
self.assertTrue(task.cancelled())
351351

352352
async def test_wait_for_clarification_cancelled(self):
353353
"""Test waiting for clarification when cancelled."""
@@ -368,7 +368,7 @@ async def cancel_task():
368368
_ = await task
369369

370370
await cancel_task_handle
371-
self.assertTrue(cancel_task_handle.done())
371+
self.assertTrue(task.cancelled())
372372

373373
def test_cleanup_approval(self):
374374
"""Test cleanup approval."""

0 commit comments

Comments
 (0)